Skip to content

QueryDsl integration [DATAES-219] #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Dec 6, 2015 · 7 comments
Closed

QueryDsl integration [DATAES-219] #792

spring-projects-issues opened this issue Dec 6, 2015 · 7 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Kevin Leturc opened DATAES-219 and commented

QueryDsl support for Spring Data Elasticsearch.

Integration of querydsl-elasticsearch project


Referenced from: pull request #134

3 votes, 6 watchers

@spring-projects-issues
Copy link
Author

Kevin Leturc commented

The pull request needs this one also : spring-projects/spring-data-build#223

@spring-projects-issues
Copy link
Author

Artur Konczak commented

Hi Kevin

I have incorporated your pull request into branch - https://github.com/spring-projects/spring-data-elasticsearch/tree/DATAES-219
Changes from my side:

  • rebase
  • update code to support ES 2.x

This branch has dependency with external project querydsl-contrib and pull request :

querydsl/querydsl-contrib#19

OR

querydsl/querydsl-contrib#16

@spring-projects-issues
Copy link
Author

Artur Konczak commented

So we need to wait for QueryDSL to approve one of the pulls.

@spring-projects-issues
Copy link
Author

Kevin Leturc commented

Hi Arthur,

Thanks to review my PR.
If you want to assign me some work on it feel free :).

You can also assign me some bug after it'll be merged

@spring-projects-issues
Copy link
Author

Steven Zgaljic commented

+1 would really love this integration.

@spring-projects-issues
Copy link
Author

sothawo commented

querydsl-elasticsearch in the last available version supports Elasticsearch 2.2.2. There seems to be no further support for the actual versions.

So can this issue (and the corresponding PR) be closed?

@spring-projects-issues
Copy link
Author

sothawo commented

closing this, as the latest supported version of Elasticsearch in Querydsl is 2.2.2 whic is not supported by Spring Data Elasticsearch anymore

@spring-projects-issues spring-projects-issues added status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant