Skip to content

SslInfo does not use its Clock when checking certificate validity #45573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wilkinsona opened this issue May 15, 2025 · 0 comments
Open

SslInfo does not use its Clock when checking certificate validity #45573

wilkinsona opened this issue May 15, 2025 · 0 comments
Labels
for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged

Comments

@wilkinsona
Copy link
Member

I noticed this as I was confused by SslMeterBinderTests where there are several certificates that are considered valid despite the tests using a fixed clock of 2024-10-21T13:51:40Z and the certificates not being valid until 2024-10-22.

While the Clock is new in 3.5, we may want to do something in 3.4 as well because SslInfoTests will start failing in the future when the certificates used for testing expire. They could prevent someone from rebuilding a tag unless they disable the tests.

Flagging for discussion so that we can decide what to do.
@wilkinsona wilkinsona added for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilkinsona