Skip to content

Add Testcontainers at development time integration test #38045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
philwebb opened this issue Oct 25, 2023 · 5 comments
Open

Add Testcontainers at development time integration test #38045

philwebb opened this issue Oct 25, 2023 · 5 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: task A general task
Milestone
3.3.x

Comments

@philwebb
Copy link
Member

Ideally we should have a test that catches issues like #37989
@philwebb philwebb added the type: task A general task label Oct 25, 2023
@philwebb philwebb added this to the 3.1.x milestone Oct 25, 2023
@scottfrederick scottfrederick changed the title Add testcontainers at development time intergration test Add Testcontainers at development time integration test Oct 25, 2023
@Wzy19930507
Copy link
Contributor

Wzy19930507 commented Oct 26, 2023 •
edited
Loading

Hi, @philwebb may i join this task?

@philwebb
Copy link
Member Author

I'm sorry @Wzy19930507 but I don't have time to actually look into this one right now. Feel free to have a go at fixing it if you like, but I won't be able to provide much guidance at the moment.

@Wzy19930507

This comment was marked as outdated.

Sign in to view
Wzy19930507 pushed a commit to Wzy19930507/spring-boot that referenced this issue Nov 3, 2023
Add Testcontainers at development time integration test
d41dcf2 
Closes spring-projectsgh-38045
@Wzy19930507 Wzy19930507 mentioned this issue Nov 3, 2023
Closed
@philwebb philwebb added the status: pending-design-work Needs design work before any code can be developed label Nov 8, 2023
@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.2.x May 23, 2024
@eddumelendez
Copy link
Contributor

@philwebb I think this issue can be closed due to has been properly tested in #37989, right?

@philwebb
Copy link
Member Author

I think we ended up manually testing the fix for #37989, I'd like to see if we can an actual integration test that fails the build if we accidentally reintroduce the problem.

@philwebb philwebb modified the milestones: 3.2.x, 3.3.x Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed type: task A general task
Projects
None yet
Milestone
3.3.x
Development

Successfully merging a pull request may close this issue.

Add Testcontainers at development time integration test Wzy19930507/spring-boot
4 participants
@philwebb @eddumelendez @Wzy19930507 @mhalbritter