Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Buffers #4

Open
chopper opened this issue Feb 24, 2015 · 0 comments
Open

Support for Buffers #4

chopper opened this issue Feb 24, 2015 · 0 comments

Comments

@chopper
Copy link

chopper commented Feb 24, 2015

gulp-aws currently claims it only supports streams (index.js, lines 34-38):

        // Only streams supported
        if (file.isBuffer()) {
            this.emit('error', new PluginError(PLUGIN_NAME, new Error('Only streams supported'), { showStack: true }));
            return done();
        }

However none of the functionality seems to be particular to streams. In fact, after commenting out the above lines, the plugin works fine with buffered streams. I suggest removing the above check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant