Operator Helm Chart v3.3.0 fails at 1st launch

[paretl]

Expected behaviour

Launch the Operator Helm chart v3.3.0 (latest one today)

Actual behaviour

It fails fast and the error is:

STDERR:
Error: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

When digging a little bit, I saw that the crds/databases.spotahome.com_redisfailovers.yaml file has these lines:

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  annotations:
    {{- with .Values.crds.annotations }}
    {{- toYaml . | nindent 4 }}
    {{- end }}
    controller-gen.kubebuilder.io/version: (devel)
  creationTimestamp: null
  name: redisfailovers.databases.spotahome.com

So I guess that the go template part in annotations is not expected here

Steps to reproduce the behavior

⚠️ Be sure that you have no current RedisFailover CRD installed. Otherwise, there is no failure. I usually remove the entire release to be sure that everything is removed.

To reproduce, launch the redis-operator chart with v3.3.0.

Environment

How are the pieces configured?

• Redis Operator version: v1.3.0-rc1 but it fails for any versions
• Kubernetes version: v1.27

Logs

There is no more details about this error in the logs with the --debug flag.

[paretl]

Ok I saw that the change is already included in the PR #651

I have created a sub-PR with only this fix to be able to use the latest version of the chart without waiting the approval/test of the other changes: #655

[zeddit]

I am facing the same issue, should I wait for the upstream helm chart to be updated. thanks

[ebuildy]

we need such annotations for argocd, I have opened #656 to harcode it

[haliliceylan]

In argocd, I am not able to use this chart. When the planning release time ?

[ebuildy]

there is a PR to fix it #656 - waiting for some approvals

[xolott]

Same error, trying to deploy the operator into an AKS cluster.

[Avnshrai]

same error, when it is going to get fixed?
I am not able to try it for my use case because of this issue

[zeddit]

hi, any progress on this.
I am looking forward to the feature of exposing redis master IP directly.
great thanks.

[sylvainOL]

Hello, any news?

[Avnshrai]

don't know what is taking too long to merge a PR, I can see just by removing those annotations operator is working fine, and in values.yaml there is a wrong image tag, need to provide v1.3.0-rc instead of v1.3.0 as I can see there is no image with v1.3.0

[lenaxia]

For anyone interested, I got 3.3.0 to install using this method:

1. Download a local copy of the CRDs to your HelmRelease as crds.yaml
2. Fix the annotation in the crds.yaml
3. Disable CRD installation in your HR by setting spec.values.crds.enabled: false
4. install the CRDs via kustomize, by adding crds.yaml to your kustomization.yaml file

[github-actions]

This issue is stale because it has been open for 45 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.