Skip to content

Commit b0e78c1

Browse files
authored
Merge pull request #417 from splunk/requirement_test/parallel_field_level
assert Field check plus DM check together
2 parents ddbf6e0 + 2a56119 commit b0e78c1

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

pytest_splunk_addon/standard_lib/requirement_tests/test_templates.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -172,12 +172,6 @@ def test_requirement_params(
172172
)
173173
self.logger.info(f"Data model check: {datamodel_check}")
174174
sourcetype = keyValue_dict_SPL["_sourcetype"]
175-
assert datamodel_check, (
176-
f"data model check: {datamodel_check} \n"
177-
f"data model in requirement file {model_datalist}\n "
178-
f"data model extracted by TA {list(datamodel_based_on_tag.keys())}\n"
179-
f"sourcetype of ingested event: {sourcetype} \n"
180-
)
181175
field_extraction_check, missing_key_value = self.compare(
182176
keyValue_dict_SPL, key_values_xml
183177
)
@@ -188,8 +182,11 @@ def test_requirement_params(
188182
valueInSplunk = keyValue_dict_SPL[key]
189183
mismapped_key_value_pair.update({key: valueInSplunk})
190184

191-
assert field_extraction_check, (
192-
f"Issue with the field extraction.\nsearch={search}\n"
185+
assert datamodel_check and field_extraction_check, (
186+
f" Issue with either field extraction or data model.\nsearch={search}\n"
187+
f" data model check: {datamodel_check} \n"
188+
f" data model in requirement file {model_datalist}\n "
189+
f" data model extracted by TA {list(datamodel_based_on_tag.keys())}\n"
193190
f" Field_extraction_check: {field_extraction_check} \n"
194191
f" Key value not extracted by TA: {missing_key_value} \n"
195192
f" Mismatched key value: {mismapped_key_value_pair}\n"

0 commit comments

Comments
 (0)