Merge pull request #31 from splunk/fix_linting_errors

Fixed most linting warnings and a bug that was encountered when running Ansible against a host that has Splunk in a stopped state

Author: Mason Morales

roles/splunk/handlers/main.yml

@@ -11,7 +11,7 @@
   loop:
     - ulimit -Hn 65536
     - ulimit -Sn 32768
-  become: yes
+  become: true
   ignore_errors: true
   when: splunk_use_initd and ansible_os_family == "RedHat" and ansible_distribution_major_version|int > 6
 
@@ -20,29 +20,29 @@
     path: /etc/init.d/splunk
     regexp: '(start --no-prompt --answer-yes)$'
     replace: '\1 --accept-license'
-  become: yes
+  become: true
   when: splunk_use_initd
 
 - name: reload systemctl daemon
   systemd:
-    daemon_reload: yes
-  become: yes
+    daemon_reload: true
+  become: true
 
 - name: stop splunk
   service:
     name: "{{ splunk_service }}"
     state: stopped
-  become: yes
+  become: true
 
 - name: start splunk
   service:
     name: "{{ splunk_service }}"
     state: started
-  become: yes
+  become: true
 
 - name: apply indexer cluster bundle
   command: "{{ splunk_home }}/bin/splunk apply cluster-bundle --answer-yes --skip-validation -auth {{ splunk_auth }}"
-  become: yes
+  become: true
   become_user: "{{ splunk_nix_user }}"
   register: apply_cluster_bundle_result
   changed_when: apply_cluster_bundle_result.rc == 0
@@ -53,15 +53,15 @@
   when: "'clustermaster' in group_names"
 
 - name: reload deployment server
-  shell: "{{ splunk_home }}/bin/splunk reload deploy-server -auth {{ splunk_auth }}"
-  become: yes
+  command: "{{ splunk_home }}/bin/splunk reload deploy-server -auth {{ splunk_auth }}"
+  become: true
   become_user: "{{ splunk_nix_user }}"
   no_log: true
   when: "'deploymentserver' in group_names"
 
 - name: apply shcluster-bundle
   command: "{{ splunk_home }}/bin/splunk apply shcluster-bundle -preserve-lookups true --answer-yes -auth {{ splunk_auth }} -target {{ deploy_target }}"
-  become: yes
+  become: true
   become_user: "{{ splunk_nix_user }}"
   register: apply_shcluster_bundle_result
   changed_when: apply_shcluster_bundle_result.rc == 0
@@ -75,9 +75,8 @@
   service:
     name: "{{ splunk_service }}"
     state: restarted
-  become: yes
+  become: true
 
 - name: restart auditd service
   command: service auditd condrestart
-  become: yes
-
+  become: true

roles/splunk/tasks/add_crashlog_script.yml

@@ -6,7 +6,7 @@
     owner: root
     group: root
     mode: 0755
-  become: yes
+  become: true
 
 - name: Configure cron to run cleanup_crashlogs.sh daily at midnight
   cron:
@@ -15,4 +15,4 @@
     job: "{{ splunk_home }}/cleanup_crashlogs.sh"
     hour: 0
     minute: 0
-  become: yes
+  become: true

roles/splunk/tasks/add_diag_script.yml

@@ -6,7 +6,7 @@
     owner: root
     group: root
     mode: 0755
-  become: yes
+  become: true
 
 - name: Configure cron to run cleanup_diags.sh daily at midnight
   cron:
@@ -15,4 +15,4 @@
     job: "{{ splunk_home }}/cleanup_diags.sh"
     hour: 0
     minute: 0
-  become: yes
+  become: true

roles/splunk/tasks/add_pstack_script.yml

@@ -6,4 +6,4 @@
     owner: "{{ splunk_nix_user }}"
     group: "{{ splunk_nix_group }}"
     mode: 0755
-  become: yes
+  become: true

roles/splunk/tasks/adhoc_clean_dispatch.yml

@@ -3,8 +3,8 @@
   include_tasks: splunk_stop.yml
 
 - name: Clean dispatch directory of all files
-  shell: "rm -rf {{ splunk_home }}/var/run/splunk/dispatch/*"
-  become: yes
+  command: "rm -rf {{ splunk_home }}/var/run/splunk/dispatch/*"
+  become: true
 
 - name: Start Splunk
   include_tasks: splunk_start.yml

roles/splunk/tasks/adhoc_configure_hostname.yml

@@ -2,15 +2,15 @@
 - name: Set the system's hostname to the inventory_hostname
   hostname:
     name: "{{ inventory_hostname }}"
-  become: yes
+  become: true
 
 - name: "Update serverName in {{ splunk_home }}/etc/system/local/server.conf"
   lineinfile:
     dest: "{{ splunk_home }}/etc/system/local/server.conf"
     state: present
     regexp: "^serverName = .*"
     line: "serverName = {{ ansible_hostname }}"
-  become: yes
+  become: true
   become_user: "{{ splunk_nix_user }}"
   notify: restart splunk
 
@@ -20,6 +20,6 @@
     state: present
     regexp: "^host = .*"
     line: "host = {{ ansible_hostname }}"
-  become: yes
+  become: true
   become_user: "{{ splunk_nix_user }}"
   notify: restart splunk

roles/splunk/tasks/adhoc_decom_indexer.yml

@@ -1,7 +1,7 @@
 ---
 - name: Execute splunk offline --enforce-counts
-  shell: "{{ splunk_home }}/bin/splunk offline --enforce-counts -auth {{ splunk_auth }}"
-  become: yes
+  command: "{{ splunk_home }}/bin/splunk offline --enforce-counts -auth {{ splunk_auth }}"
+  become: true
   become_user: "{{ splunk_nix_user }}"
   no_log: true
   when: "'indexer' in group_names"

roles/splunk/tasks/adhoc_fix_mongo.yml

@@ -6,22 +6,22 @@
     mode: 0600
     owner: "{{ splunk_nix_user }}"
     group: "{{ splunk_nix_group }}"
-  become: yes
+  become: true
 
 - name: Delete mongod.lock if present
   file:
     state: absent
     path: "{{ splunk_home }}/var/lib/splunk/kvstore/mongo/mongod.lock"
-  become: yes
+  become: true
 
 - name: Update file permissions for journal
   file:
     state: directory
-    recurse: yes
+    recurse: true
     path: "{{ splunk_home }}/var/lib/splunk/kvstore/mongo/journal"
     mode: 0710
     owner: "{{ splunk_nix_user }}"
     group: "{{ splunk_nix_group }}"
-  become: yes
+  become: true
 
 # Also consider adhoc_fix_server_certificate.yml if the cert is expired and you are using the default cert for kvstore

roles/splunk/tasks/adhoc_fix_server_certificate.yml

@@ -2,8 +2,8 @@
 # To check if cert is expired:  splunk cmd openssl x509 -in /opt/splunk/etc/auth/server.pem -text -noout
 # Note: Genereates new default certificate. Do not use this if you generate/sign your own splunkd certificate
 - name: Remove old server.pem certificate and generate a new one
-  shell: "{{ item }}"
-  become: yes
+  command: "{{ item }}"
+  become: true
   become_user: "{{ splunk_nix_user }}"
   loop:
     - "rm {{ splunk_home }}/etc/auth/server.pem"

roles/splunk/tasks/adhoc_kill_splunkd.yml

@@ -1,4 +1,4 @@
 ---
 - name: Kill any stale splunkd processes
   shell: for i in $(ps -ef | grep splunkd -i | grep -v grep | awk '{print $2}'); do kill -9 $i; done
-  become: yes
+  become: true