Skip to content

docs: change the runbok for appinspect update #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kdoroszko-splunk
Copy link
Contributor

@kdoroszko-splunk kdoroszko-splunk commented May 6, 2025

Description

I think it makes more sense to make a fix release each time we update appinspect version. We'd prevent ourselves from rolling out the template each time there is a feat release of appinspect.

Checklist

  • README.md has been updated or is not required
  • push trigger tests
  • manual release test
  • automated releases test
  • pull request trigger tests
  • schedule trigger tests
  • workflow errors/warnings reviewed and addressed

Testing done

No tests are needed

@kdoroszko-splunk kdoroszko-splunk requested a review from a team as a code owner May 6, 2025 09:31
@mkolasinski-splunk
Copy link
Contributor

@kdoroszko-splunk Would rollout really be necessary in such case? Wouldn't releasing a patch for reusable workflow with bumped version of appinspect action be enough?
I'm bit worried for automated feat versions updates that may eventually break the workflows.

@kdoroszko-splunk
Copy link
Contributor Author

@kdoroszko-splunk Would rollout really be necessary in such case? Wouldn't releasing a patch for reusable workflow with bumped version of appinspect action be enough? I'm bit worried for automated feat versions updates that may eventually break the workflows.

I think we're on the same page here: I'd like to always make patch release of reusable workflow when appisnspect is updated.
However, at the moment the documentation says to create a "feat" PR directly to main branch, which per my understanding will create a minor release of reusable workflow (and then the rollout is required).

@kdoroszko-splunk kdoroszko-splunk merged commit 1f26798 into develop May 6, 2025
6 checks passed
@kdoroszko-splunk kdoroszko-splunk deleted the docs/update-runbook-for-appinspect-update branch May 6, 2025 10:11
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants