Skip to content

Commit 73f1bd9

Browse files
committed
fixed bug in rule based segments
1 parent a09aed1 commit 73f1bd9

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,5 @@
4343
- Updated to support harness mode
4444
3.5.1 (June 20, 2025)
4545
- Updated to support rule based segments
46+
3.5.2 (June 20, 2025)
47+
- fixed bug in updating rule based segments

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ rules_data = {
401401
}
402402

403403
# Update the segment definition with the rules
404-
updated_segdef = segdef.update(rules_data)
404+
updated_segdef = segdef.update(rules_data) # the workspace id is passed in from the find operation - so it's not needed here
405405
```
406406

407407
Update Rule-Based Segment definition with excluded keys and excluded segments:

splitapiclient/microclients/rule_based_segment_definition_microclient.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def list(self, environment_id, workspace_id, offset=0, limit=50):
7979
if isinstance(response, list):
8080
for item in response:
8181
item['environment'] = {'id':environment_id, 'name':''}
82-
current_page_items.append(RuleBasedSegmentDefinition(item, self._http_client))
82+
current_page_items.append(RuleBasedSegmentDefinition(item, self._http_client, workspace_id=workspace_id))
8383

8484
# Add current page items to the full list
8585
segment_definition_list.extend(current_page_items)

0 commit comments

Comments
 (0)