Fix for setting the unittest root dir

Author: Mytherin

CMakeLists.txt

@@ -429,7 +429,6 @@ option(DEBUG_MOVE "Debug setting: Ensure std::move is being used" FALSE)
 option(VERIFY_VECTOR "Debug setting: verify vectors (options: dictionary_expression, dictionary_operator, constant_operator, sequence_operator, nested_shuffle)" "none")
 option(CLANG_TIDY "Enable build for clang-tidy, this disables all source files excluding the core database. This does not produce a working build." FALSE)
 option(BUILD_UNITTESTS "Build the unittest runner." TRUE)
-option(UNITTEST_ROOT_DIRECTORY "The unittest root directory (defaults to the project source directory)" FALSE)
 option(ENABLE_UNITTEST_CPP_TESTS "Build the C++ Unit Tests." TRUE)
 option(EXTENSION_CONFIG_BUILD "Produce extension configuration artifacts instead of building. (such as shared vcpkg.json, extensions.txt)" FALSE)
 option(CUSTOM_LINKER "Use a custom linker program" "")

test/CMakeLists.txt

@@ -33,7 +33,8 @@ if(NOT WIN32 AND NOT SUN)
   add_subdirectory(persistence)
 endif()
 
-if(${UNITTEST_ROOT_DIRECTORY})
+set(UNITTEST_ROOT_DIRECTORY "" CACHE STRING "The unittest root directory (defaults to the project source directory)")
+if(DEFINED UNITTEST_ROOT_DIRECTORY AND NOT UNITTEST_ROOT_DIRECTORY STREQUAL "")
   add_definitions(-DDUCKDB_ROOT_DIRECTORY="${UNITTEST_ROOT_DIRECTORY}")
 else()
   add_definitions(-DDUCKDB_ROOT_DIRECTORY="${PROJECT_SOURCE_DIR}")