Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: spinnaker/echo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.43.0
Choose a base ref
...
head repository: spinnaker/echo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 13 commits
  • 129 files changed
  • 12 contributors

Commits on Nov 27, 2024

  1. chore(dependencies): Autobump korkVersion (#1462)

    Co-authored-by: root <root@df07caf89e8f>
    spinnakerbot and root authored Nov 27, 2024
    Copy the full SHA
    8d260df View commit details
  2. chore(dependencies): Autobump fiatVersion (#1464)

    Co-authored-by: root <root@c80011301680>
    spinnakerbot and root authored Nov 27, 2024
    Copy the full SHA
    ca6b4ce View commit details

Commits on Dec 10, 2024

  1. chore(dependencies): Autobump fiatVersion (#1465)

    Co-authored-by: root <root@4f180b5207b5>
    spinnakerbot and root authored Dec 10, 2024
    Copy the full SHA
    469d50f View commit details

Commits on Jan 9, 2025

  1. refactor(retrofit2): replace retrofit client with retrofit2 client (#…

    …1466)
    
    * refactor(retrofit2): upgrade KeelService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade CDEventsSenderClient retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade BearychatService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade JiraService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade GoogleChatClient retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade GithubService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade SlackClient retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade PagerDutyService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade MicrosoftTeamsClient retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade TelemetryService retrofit API interface to retrofit2
    
    * refactor(retrofit2): move Retrofit2TestConfig from echo-notification/src/test/.. to echo-test/src/main/.. so that other modules can utilize
    
    * refactor(retrofit2): upgrade RestService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade TwilioService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade OrcaService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade IgorService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade SlackHookService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade SpinnakerService retrofit API interface to retrofit2
    
    * refactor(retrofit2): upgrade Front50Service retrofit API interface to retrofit2
    
    * refactor(retrofit2): Remove RetrofitError from JiraNotificationService
    
    * refactor(retrofit2): remove remaining references to retrofit1
    
    * refactor(retrofit2): Convert Retrofit2TestConfig to java
    
    * refactor(retrofit2): move java classes from main/groovy/.. to main/java/.. in echo-notifications
    
    * refactor(retrofit2): replaced retrofit1's encode=false flag to retrofit2's encoded=true
    
    * refactor(retrofit2): addressed review comments
    kirangodishala authored Jan 9, 2025
    Copy the full SHA
    6a0e784 View commit details
  2. chore(dependencies): Autobump korkVersion (#1468)

    Co-authored-by: root <root@935cb5015720>
    spinnakerbot and root authored Jan 9, 2025
    Copy the full SHA
    58f6a79 View commit details

Commits on Jan 28, 2025

  1. chore(dependencies): Autobump korkVersion (#1470)

    Co-authored-by: root <root@d6aa4183a5bc>
    spinnakerbot and root authored Jan 28, 2025
    Copy the full SHA
    b28e91b View commit details

Commits on Feb 7, 2025

  1. chore(dependencies): Autobump korkVersion (#1471)

    Co-authored-by: root <root@796c595fa7d4>
    spinnakerbot and root authored Feb 7, 2025
    Copy the full SHA
    e237af0 View commit details

Commits on Feb 12, 2025

  1. fix(ubuntu): add commands so apt-get can install libc (#1473)

    specifically:
    
    rm /var/lib/dpkg/info/libc-bin.* && apt-get clean
    
    to fix errors like
    
    #9 97.43 Processing triggers for libc-bin (2.35-0ubuntu3.8) ...
    #9 97.51 qemu: uncaught target signal 11 (Segmentation fault) - core dumped
    #9 97.90 Segmentation fault (core dumped)
    #9 97.95 qemu: uncaught target signal 11 (Segmentation fault) - core dumped
    #9 98.32 Segmentation fault (core dumped)
    #9 98.32 dpkg: error processing package libc-bin (--configure):
    #9 98.32  installed libc-bin package post-installation script subprocess returned error exit status 139
    
    from https://github.com/spinnaker/echo/actions/runs/13294114983/job/37121759834?pr=1472
    
    suggestion from https://stackoverflow.com/a/78107622
    dbyron-sf authored Feb 12, 2025
    Copy the full SHA
    2abe92d View commit details

Commits on Feb 13, 2025

  1. chore(dependencies): Autobump korkVersion (#1472)

    Co-authored-by: root <root@b3aa3eba8e03>
    spinnakerbot and root authored Feb 13, 2025
    Copy the full SHA
    b002246 View commit details
  2. Copy the full SHA
    a7887b2 View commit details

Commits on Feb 19, 2025

  1. chore(dependencies): Autobump fiatVersion (#1475)

    Co-authored-by: root <root@819552d2cd6b>
    spinnakerbot and root authored Feb 19, 2025
    Copy the full SHA
    b7bfb53 View commit details

Commits on Feb 27, 2025

  1. fix(retrofit2): fix baseUrl must end in / error (#1476)

    * test(retrofit2): add a test to demonstrate the error: java.lang.IllegalArgumentException: baseUrl must end in /.
    
    * fix(retrofit2): fix the following error by adding trailing / in the baseUrl and removing leading / in the end point:
    java.lang.IllegalArgumentException: baseUrl must end in /.
    
    * fix(retrofit2): fix RestService by replacing POST mapping from / to . and add a test class to demonstrate the behaviour.
    
    Here are some references that justify this change:
    square/retrofit#907,
    square/retrofit#1701
    kirangodishala authored Feb 27, 2025
    Copy the full SHA
    19e2f34 View commit details
  2. fix(retrofit2): fix A @path parameter must not come after a @Query

    …error (#1478)
    
    * test(retrofit2): add a test to demonstrate the following error:
    java.lang.IllegalArgumentException: A @path parameter must not come after a @query.
    
    * fix(retrofit2): fix `A @path parameter must not come after a @Query` error
    kirangodishala authored Feb 27, 2025
    Copy the full SHA
    f170364 View commit details
Loading