-
Notifications
You must be signed in to change notification settings - Fork 270
Local Service Chaining blocks spin start #3088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I tried this in one of my app by just modifying the spin.toml and adding
from spin.toml
|
do you happen to have this app published somewhere I can try from? |
Ok. I will get a generalized example of this issue. |
You can check this tree: https://github.com/seungjin/foo.fermyon.app/tree/9559ed0324db9073c0a4f39afa45397abfd18f95 Seems this happens only when I mix http and cron triggers. |
At the moment, unfortunately, you can only service chain from HTTP components to HTTP components.
https://spinframework.dev/v3/http-outbound#making-http-requests-within-an-application We should for sure do a better job of reporting the limitation - Spin should at least stop with a clear error message. I'll look into this. |
What about this: https://github.com/seungjin/foo.fermyon.app/blob/4f0b262d8b96283df91b7763d96ee352a77262aa/spin.toml#L31 |
That does sound like a bug - thanks for clarifying! I will take a look. |
I have a suspicion this has a similar cause to #2915. Both multi-trigger and app splitting involve subsetting the components, and the "must support service chaining" host requirement is naively propagated to each subset, whereas it should be recalculated for each subset. (ETA: Actually I think this is the same issue as #2915. I thought there was another one for subsetting but #2915 implies that it was already fixed for subsetting. In which case I might not be able to back some stuff out!) (ETAYM: It was not already fixed for subsetting.) |
Hmm, maybe multi-trigger is not subsetting - maybe the subsetting is done within the trigger command (and all triggers receive the same lockfile). That would have been easier to implement for sure, but makes the fix more difficult. I'm wondering if, now we have subsetting, we can refit multi-trigger to use the same logic, then fix the subsetting logic just once. Not sure how painful that will be but I will keep digging. |
Okay I have a candidate fix, and it looks to fix #2915 as well. It's a bit revolting and results in multiple passes and multiple parsings which seems a bit, well, unparsimonious. But now I know it seems to work I can tidy it up and see if there are any opportunities to make it repeat work less (and give it fuller testing). Unlikely to be ready to PR today but hopefully tomorrow! |
Getting this error at spin startup and can't start spin up.
only when I add this into my spin.toml
Other normal urls are fine, just Spin's Local Service Chaining url emits error and block spin start.
The text was updated successfully, but these errors were encountered: