Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Manager UI Error messages upon startup #515

Open
maia-iyer opened this issue Oct 2, 2024 · 6 comments
Open

[bug] Manager UI Error messages upon startup #515

maia-iyer opened this issue Oct 2, 2024 · 6 comments
Assignees
Labels
bug Something isn't working frontend Tornjak UI (Frontend)

Comments

@maia-iyer
Copy link
Collaborator

Environment:

I deployed Tornjak backend in a local Kind cluster and the Tornjak manager backend is running locally at port 50000
Then I ran:

cd frontend
REACT_APP_API_SERVER_URI=http://localhost:50000/ REACT_APP_TORNJAK_MANAGER=true npm start

To start the frontend with the manager UI.

Error

I notice the home page for the manager is the Agents list page. When I go to any page other than the Manage Servers page, I get this in the heading:

image

Particularly, this error message does not come from the backend (there are no calls to the backend), which means there's somewhere in the frontend is assuming error code.

Potential suggestions

  1. Immediate fix is to find where this error message is coming from and remove it
  2. I think it might also make sense to have the Manage Servers page be the home page for the manager?
    a. Perhaps it might even make sense to add a hierarchical level between the pages? For example, the Manage Servers page is a higher level than the other pages that are specific to one server. Maybe a sidebar menu or something like that. I recognize this is a bigger ask, so we can open a separate issue if we decide to do this at some point - just wanted to raise the idea
@maia-iyer maia-iyer added bug Something isn't working frontend Tornjak UI (Frontend) labels Oct 2, 2024
@cstecc
Copy link

cstecc commented Oct 15, 2024

can I be assigned to this issue?

@mamy-CS
Copy link
Collaborator

mamy-CS commented Oct 16, 2024

/assign @cstecc

@cstecc
Copy link

cstecc commented Oct 23, 2024

I also used a kind cluster locally and did not get this message. this text also doesn't seem to exist anywhere within the files did someone already resolve this issue?

@maia-iyer
Copy link
Collaborator Author

I still do see some bug - Ideal behavior means that upon seeing the home page of the UI, there would be no error, but there seems to be some error. Perhaps recent development has changed the error. Here's what I see now:

image

There ideally shouldn't be any error, and a backend shouldn't be called.

Additional investigation shows that upon inspection of the network (at the bottom of the screenshot), there's a call to localhost:10000 to list. When I clicked on it, it seems to be making a call to http://localhost:10000/manager-api/server/list

This is problematic: The manager API is run at localhost:50000, so the localhost:10000 should not be known to the UI. I ran the manager UI using:

REACT_APP_API_SERVER_URI=http://localhost:50000/
REACT_APP_TORNJAK_MANAGER=true npm start

So some API call is not currently being constructed right

@maia-iyer
Copy link
Collaborator Author

This is a slightly different issue though, so @cstecc I might close this issue in favor of opening a new one. Would you be interested in working on this bug?

@cstecc
Copy link

cstecc commented Oct 25, 2024

Yes ill work on this thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Tornjak UI (Frontend)
Projects
None yet
Development

No branches or pull requests

3 participants