Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated k8s_sat node attestor plugin #5681

Open
amartinezfayo opened this issue Dec 5, 2024 · 5 comments · May be fixed by #5703
Open

Remove the deprecated k8s_sat node attestor plugin #5681

amartinezfayo opened this issue Dec 5, 2024 · 5 comments · May be fixed by #5703
Assignees
@c0d3-k1ra
Labels
good first issue Issues with this label are good candidates for first-time contributions help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Milestone
1.12.0

Comments

@amartinezfayo
Copy link
Member

The k8s_sat node attestor has been deprecated since 1.9.0, it's time to remove it.
@amartinezfayo amartinezfayo added this to the 1.12.0 milestone Dec 5, 2024
@rturner3 rturner3 added good first issue Issues with this label are good candidates for first-time contributions help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Dec 10, 2024
@c0d3-k1ra c0d3-k1ra linked a pull request Dec 11, 2024 that will close this issue
Open
3 tasks
@c0d3-k1ra
Copy link

Hello @amartinezfayo I have added a PR to remove the said plugin, please review. I went through the Contributing and governance guide in detail. This is my first PR, so please let me know if any thing should have been done differently. Thanks.

This was referenced Jan 7, 2025
Open
Closed
Open
Open
@rturner3
Copy link
Collaborator

rturner3 commented Jan 7, 2025

@c0d3-k1ra There are a few other issues in other related projects that need to be addressed before we can safely remove the k8s_sat plugin from the SPIRE repository:

@c0d3-k1ra
Copy link

@rturner3 I'll work on the above

@rturner3
Copy link
Collaborator

@c0d3-k1ra Are you still planning to work on this? We are trying to close this out for the next 1.12.0 release tentatively planned for March.

@rturner3
Copy link
Collaborator

We may want to also fix #5666 while we're addressing the SPIRE examples

rturner3 added a commit to rturner3/spire-examples that referenced this issue Mar 8, 2025
@rturner3
Replace k8s_sat NodeAttestor with k8s_psat
41e1a58 
The k8s_sat NodeAttestor plugin is deprecated and is set to be removed
from SPIRE: spiffe/spire#5681

Also update the SPIRE version to the latest.

Signed-off-by: Ryan Turner <[email protected]>
@rturner3 rturner3 mentioned this issue Mar 8, 2025
Merged
rturner3 added a commit to rturner3/spire-examples that referenced this issue Mar 8, 2025
@rturner3
Replace k8s_sat NodeAttestor with k8s_psat
816705b 
The k8s_sat NodeAttestor plugin is deprecated and is set to be removed
from SPIRE: spiffe/spire#5681

Also update the SPIRE version to the latest.

Signed-off-by: Ryan Turner <[email protected]>
rturner3 added a commit to spiffe/spire-examples that referenced this issue Mar 13, 2025
@rturner3
Replace k8s_sat NodeAttestor with k8s_psat (#107)
dfdf6dd 
The k8s_sat NodeAttestor plugin is deprecated and is set to be removed
from SPIRE: spiffe/spire#5681

Also update the SPIRE version to the latest.

Signed-off-by: Ryan Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c0d3-k1ra c0d3-k1ra

Labels
good first issue Issues with this label are good candidates for first-time contributions help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

Remove the deprecated k8s_sat node attestor plugin c0d3-k1ra/spire
3 participants
@c0d3-k1ra @rturner3 @amartinezfayo