Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lyrics-plus] Translation Display is not respected when Convert is on #3303

Closed
2 tasks done
Cyberczy opened this issue Feb 8, 2025 · 4 comments
Closed
2 tasks done
Labels
πŸ› bug Something isn't working

Comments

@Cyberczy
Copy link

Cyberczy commented Feb 8, 2025

πŸ” Have you checked Spicetify.app page for your issue?

  • I have checked the FAQ

πŸ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

β„Ή Environment / Computer Info

- Spotify version: 1.2.53.440.g7b2f582a
- Spicetify version: 2.39.2

πŸ“ Description

I wonder if this is as expected.

πŸ“Έ Screenshots

convert on

Image

convert off

Image

@Cyberczy Cyberczy added the πŸ› bug Something isn't working label Feb 8, 2025
@rxri
Copy link
Member

rxri commented Feb 8, 2025

Yeah it kinda is. Translations were handled differently than conversions to like romaji etc

@rxri rxri closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2025
@Cyberczy
Copy link
Author

Cyberczy commented Feb 8, 2025

Yeah it kinda is. Translations were handled differently than conversions to like romaji etc

What I mean is that the 'below original' feature should appear in the 'convert on' mode.

@rxri rxri reopened this Feb 8, 2025
@rxri
Copy link
Member

rxri commented Feb 8, 2025

Yeah I get what you mean now, I think originalText is unavailable when Convert is on

@rxri rxri changed the title The new version of lyrics-plus seems to have some issues with the conversion [lyrics-plus] Translation Display is not respected when Convert is on Feb 8, 2025
@Cyberczy
Copy link
Author

Cyberczy commented Feb 9, 2025

In the example above, the English is the original text, and the Chinese is the translation.

Image

Lseoksee added a commit to Lseoksee/spicetify-cli-korean that referenced this issue Feb 11, 2025
@rxri rxri closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants