-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use extra Jinja-Environment? #42
Comments
I'm not sure what you mean about escaping, can you elaborate? |
Jinja supports auto-escaping potentially problematic strings ( https://jinja.palletsprojects.com/en/2.10.x/api/#autoescaping ) which may or may not be enabled depending on the environment (builder). |
If each builder configures the environment with different escaping rules, don't we want those builder-specific settings? Or maybe not, since they are language-specific (HTML vs. RST)? |
We would want ReST escaping as that is what we parse with |
I could see escaping being useful, but I could also see it being useful to have embedded RST in the data that a user wants rendered. So it's fine if we make escaping the default, but there needs to be a way to turn it off. |
As stated in #60 how to escape depends on context so not escaping by default but having escape functions or filters seems more doable. |
Should we really use the Sphinx builder's Jinja Environment? At least escaping propably depends on the builder. Do we want that?
The text was updated successfully, but these errors were encountered: