Payment metadata is data that is encoded in an LN invoice that is supposed to be sent back to the entity that generated the invoice. This is useful for the invoice creator to not having to store invoice details or other data that can be derived from the metadata.
See:
lightning/bolts#912