Merge pull request #7 from CasEbb/main

Use more common names for Dutch holidays

Author: Nielsvanpach

src/Countries/Netherlands.php

@@ -15,11 +15,11 @@ public function countryCode(): string
     protected function allHolidays(int $year): array
     {
         return array_merge([
-            'Nieuwjaar' => '01-01',
+            'Nieuwjaarsdag' => '01-01',
             'Bevrijdingsdag' => '05-05',
-            'Kerstmis' => '12-25',
-            '2de Kerstdag' => '12-26',
-            'Oudjaar' => '12-31',
+            '1e Kerstdag' => '12-25',
+            '2e Kerstdag' => '12-26',
+            'Oudejaarsdag' => '12-31',
         ], $this->variableHolidays($year));
     }
 
@@ -37,11 +37,12 @@ protected function variableHolidays(int $year): array
 
         return [
             'Koningsdag' => $koningsDag,
-            'Goede vrijdag' => $easter->subDays(2),
-            'Paasmaandag' => $easter->addDay(),
-            'OLH Hemelvaart' => $easter->addDays(39),
-            'Pinksteren' => $easter->addDays(49),
-            'Pinkstermaandag' => $easter->addDays(50),
+            'Goede Vrijdag' => $easter->subDays(2),
+            '1e Paasdag' => $easter,
+            '2e Paasdag' => $easter->addDay(),
+            'Hemelvaartsdag' => $easter->addDays(39),
+            '1e Pinksterdag' => $easter->addDays(49),
+            '2e Pinksterdag' => $easter->addDays(50),
         ];
     }
 }

tests/.pest/snapshots/Countries/NetherlandsTest/it_can_calculate_dutch_holidays.snap

@@ -1,14 +1,18 @@
 [
     {
-        "name": "Nieuwjaar",
+        "name": "Nieuwjaarsdag",
         "date": "2024-01-01"
     },
     {
-        "name": "Goede vrijdag",
+        "name": "Goede Vrijdag",
         "date": "2024-03-29"
     },
     {
-        "name": "Paasmaandag",
+        "name": "1e Paasdag",
+        "date": "2024-03-31"
+    },
+    {
+        "name": "2e Paasdag",
         "date": "2024-04-01"
     },
     {
@@ -20,27 +24,27 @@
         "date": "2024-05-05"
     },
     {
-        "name": "OLH Hemelvaart",
+        "name": "Hemelvaartsdag",
         "date": "2024-05-09"
     },
     {
-        "name": "Pinksteren",
+        "name": "1e Pinksterdag",
         "date": "2024-05-19"
     },
     {
-        "name": "Pinkstermaandag",
+        "name": "2e Pinksterdag",
         "date": "2024-05-20"
     },
     {
-        "name": "Kerstmis",
+        "name": "1e Kerstdag",
         "date": "2024-12-25"
     },
     {
-        "name": "2de Kerstdag",
+        "name": "2e Kerstdag",
         "date": "2024-12-26"
     },
     {
-        "name": "Oudjaar",
+        "name": "Oudejaarsdag",
         "date": "2024-12-31"
     }
 ]