Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for overrides when adding iconparts #162

Closed
spatialillusions opened this issue Jan 17, 2018 · 0 comments
Closed

Check for overrides when adding iconparts #162

spatialillusions opened this issue Jan 17, 2018 · 0 comments

Comments

@spatialillusions
Copy link
Owner

All iconpart functions in milsymbol should have a check if they overwrite existing definitions, this to make sure that we don't accidentally override things that already are defined. This would give us two benifits:

  1. We would be sure that we don't mess anything up by accident.
  2. We would be able to start renaming things, Get crazy, let's rename iconparts...  #123, without messing things up.
spatialillusions added a commit that referenced this issue Jan 17, 2018
@spatialillusions
Break apart iconparts
d634af7 
So this breaks a lot of stuff and we end up with a lot of broken
symbols, but trust me, it is good in the long run, now we just need to
repair everything that I broke.
This will implement #162 and #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spatialillusions