Merge pull request #142 from ryanhertz/errors-in-errors

include the errors from the response in the instance of ClientErrors

Author: ryanhertz

CHANGELOG

@@ -1,3 +1,6 @@
+v1.4.18
+ - include the errors from the response in the instance of ClientErrors
+
 v1.4.17
  - use '/flexmls/listings' for PUT
 

VERSION

@@ -1 +1 @@
-1.4.17
+1.4.18

lib/spark_api/errors.rb

@@ -21,14 +21,15 @@ module ResponseCodes
   # Errors built from API responses
   class InvalidResponse < StandardError; end
   class ClientError < StandardError
-    attr_reader :code, :status, :details, :request_path
+    attr_reader :code, :status, :details, :request_path, :errors
     def initialize (options = {})
       # Support the standard initializer for errors
       opts = options.is_a?(Hash) ? options : {:message => options.to_s}
       @code = opts[:code]
       @status = opts[:status]
       @details = opts[:details]
       @request_path = opts[:request_path]
+      @errors = opts[:errors]
       super(opts[:message])
     end
 

lib/spark_api/faraday_middleware.rb

@@ -40,7 +40,8 @@ def on_complete(env)
         :request_path => env[:url],
         :message => response.message,
         :code => response.code,
-        :status => env[:status]
+        :status => env[:status],
+        :errors => body['D']['Errors']
       }
 
       case env[:status]

spec/unit/spark_api/faraday_middleware_spec.rb

@@ -48,6 +48,13 @@
             "Code": "0000"
           }}'] 
         }
+        stub.get('/badresourcerequest') { [409, {}, '{"D": {
+            "Message": "FlexmlsApiResponse::Errors::Errors", 
+            "Code": 1053, 
+            "Success": false, 
+            "Errors": "Some errors and stuff."
+          }}'] 
+        }
         stub.get('/invalidjson') { [200, {}, '{"OMG": "THIS IS NOT THE API JSON THAT I KNOW AND <3!!!"}'] }
         stub.get('/garbage') { [200, {}, 'THIS IS TOTAL GARBAGE!'] }
       end
@@ -85,6 +92,12 @@
       response.results.length.should be > 0 
     end
 
+    it "should include the errors in the response" do
+      expect { @connection.get('/badresourcerequest')}.to raise_error(SparkApi::BadResourceRequest){ |e| 
+        e.errors.should == "Some errors and stuff."
+      }
+    end
+
   end
 
   describe "#decompress_body" do