Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test for scripts/create_conda_env.sh #322

Open
timsnyder opened this issue Mar 31, 2022 · 7 comments
Open

Create test for scripts/create_conda_env.sh #322

timsnyder opened this issue Mar 31, 2022 · 7 comments
Labels
enhancement Enhancement or request

Comments

@timsnyder
Copy link
Contributor

The availability of packages in conda-forge and changes in conda/mamba dependency solver impacts the ability of scripts/create_conda_env.sh to solve the environment (e.g. #145 ). Plus, I know there are assumptions in there that can be broken by edits to conda.recipe/ followed by conda smithy rerender (e.g. #227 & #228)

I don't think we should regress that script all the time with the rest of map but we should:

  • test it whenever there are changes to conda.recipe
  • test it periodically to ensure that changes to
  • test it with mamba and conda to get some additional coverage and confidence with the new dep solver

mamba is the reimplementation of the dependency solver in C++

For this, I would create a GitHub Actions workflow so that it doesn't conflict with the auto-generated CI stuff.

@knute-sifive, @MichaelSchoenfelder-SiV , @benoy-sifive I don't know how important you guys think this is. Since I haven't been doing things with sparta and projects that use it, I'm not sure how often people have run into issues with my janky script or not. Actually, I'm just realizing after looking at it that the variant yamls have gotten simplified and need to be updated again.. lol.

@ghost
Copy link

ghost commented Mar 31, 2022

So far, no issues for me, but a newer/regressed form of this flow would be great. As the RISC-V International has adopted Sparta as the framework of choice, I expect more people will want to use it.

@ghost ghost added the enhancement Enhancement or request label Jun 6, 2023
@timsnyder
Copy link
Contributor Author

#446 (reply in thread) points out a case where create_conda_env.sh is broken. IT's also definitely broken for me when I try to run it.

@klingaard
Copy link
Member

klingaard commented Mar 17, 2024

I think it just recently broke too. I had a colleague at work try it in WSL and it was more work than expected. Back to just listing requirements? That'd suck.

@timsnyder
Copy link
Contributor Author

Ok. I fixed it for myself this past weekend. I'll try to push something this week that fixes it.

@klingaard
Copy link
Member

Much appreciated!

@adrenaholicgeek
Copy link
Contributor

adrenaholicgeek commented Apr 5, 2024

I have the same problem, was able to run it around a month ago and now it's just broken and hangs forever.

@adrenaholicgeek
Copy link
Contributor

Mine was #488 (comment). After the fix, the script worked correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or request
Projects
None yet
Development

No branches or pull requests

3 participants