Demos fail to build due to conflict with different demo

[ivanperez-keera]

Version or commit hash

01e9881

Steps to reproduce issue and expected behavior

The ros_trick and space_robots demos are failing to build in CI because their build process attempts to install the lunarsim demo, which is based on Humble, not Jazzy.

These demos should not pull that in and should build correctly.

Actual behavior

Build is failing.

Backtrace or Console output

See:

• https://github.com/space-ros/demos/actions/runs/21071870781/job/60603431128#step:3:11968
• https://github.com/space-ros/demos/actions/runs/21071870781/job/60603431096#step:3:12206

Notes

The PR after which this was noticed built correctly: #51.

[ivanperez-keera]

Tagging @asimonov @mkhansenbot for awareness.

[ivanperez-keera]

@mkhansenbot do you know why those two demos try to build something in a different demo?

[asimonov]

@ivanperez-keera , actually the problem here is the gazebo (or rather ignition) package from lunar_terrain pulled into demos_ws when space_robots is built.

the error:
https://github.com/space-ros/demos/actions/runs/21071870781/job/60603431128#step:3:11956

here is where entire demos repo is pulled into workspace when building space_robots:
https://github.com/space-ros/demos/blob/main/space_robots/Dockerfile#L57

For ros_trick demo the problem is the same - ignition package for lunar_terrain: https://github.com/space-ros/demos/actions/runs/21071870781/job/60603431128

I suggest we test/merge #137. This will fix both of these errors.

the open question is - why we pull all demos packages when building space_robots and ros_trick... In fact looks like RACS2 demo is explicitly removed from space_robots as I presume it was causing similar sort of problems: https://github.com/space-ros/demos/blob/main/space_robots/Dockerfile#L60

[asimonov]

we can also remove lunar_terrain from space_robots and ros_trick build in PR for this issue, if you want

[ivanperez-keera]

we can also remove lunar_terrain from space_robots and ros_trick build in PR for this issue, if you want

I really think this is the right way to go about it.

We should be able to have demos in this repo against different versions of Space ROS / ROS 2 and Gazebo.

[asimonov]

@ivanperez-keera , the PR is in. looks like it solves the problem.

can you merge? then I would rebase the lunar_terrain

[ivanperez-keera]

On it.