Enable performance-* clang-tidy checks (#1860)

Signed-off-by: Balakrishna Avulapati <[email protected]>

Author: bavulapati

cmake/common/clang-tidy.config

@@ -1,5 +1,5 @@
 {
-  "Checks": "-*, concurrency-*, modernize-*, portability-*",
+  "Checks": "-*, concurrency-*, modernize-*, performance-*, portability-*",
   "WarningsAsErrors": "*",
   "FormatStyle": "none",
   "UseColor": true

src/core/json/include/sourcemeta/core/json_value.h

@@ -45,7 +45,7 @@ class SOURCEMETA_CORE_JSON_EXPORT JSON {
   /// The object type used by the JSON document.
   using Object = JSONObject<String, JSON, PropertyHashJSON<JSON::String>>;
   /// The parsing phase of a JSON document.
-  enum class ParsePhase { Pre, Post };
+  enum class ParsePhase : std::uint8_t { Pre, Post };
   // The enumeration indexes must stay in sync with the internal variant
   /// The different types of a JSON instance.
   enum class Type : std::uint8_t {

src/core/jsonpointer/include/sourcemeta/core/jsonpointer_template.h

@@ -5,6 +5,7 @@
 
 #include <algorithm>        // std::copy, std::all_of
 #include <cassert>          // assert
+#include <cstdint>          // std::uint8_t
 #include <initializer_list> // std::initializer_list
 #include <iterator>         // std::back_inserter
 #include <optional>         // std::optional, std::nullopt
@@ -16,7 +17,7 @@ namespace sourcemeta::core {
 /// @ingroup jsonpointer
 template <typename PointerT> class GenericPointerTemplate {
 public:
-  enum class Wildcard { Property, Item, Key };
+  enum class Wildcard : std::uint8_t { Property, Item, Key };
   struct Condition {
     auto operator==(const Condition &) const noexcept -> bool = default;
     auto operator<(const Condition &) const noexcept -> bool { return false; }

src/core/jsonschema/include/sourcemeta/core/jsonschema_frame.h

@@ -105,7 +105,7 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaFrame {
 public:
   /// The mode of framing. More extensive analysis can be compute and memory
   /// intensive
-  enum class Mode { Locations, References, Instances };
+  enum class Mode : std::uint8_t { Locations, References, Instances };
 
   SchemaFrame(const Mode mode) : mode_{mode} {}
 

src/core/uri/include/sourcemeta/core/uri_escape.h

@@ -5,13 +5,14 @@
 #include <sourcemeta/core/uri_export.h>
 #endif
 
+#include <cstdint> // std::uint8_t
 #include <istream> // std::istream
 #include <ostream> // std::ostream
 
 namespace sourcemeta::core {
 
 /// @ingroup uri
-enum class URIEscapeMode {
+enum class URIEscapeMode : std::uint8_t {
   // Escape every characted that is not in the URI "unreserved" ABNF category
   // See https://www.rfc-editor.org/rfc/rfc3986#appendix-A
   SkipUnreserved,

src/extension/alterschema/include/sourcemeta/core/alterschema.h

@@ -16,11 +16,13 @@
 
 #include <sourcemeta/core/jsonschema.h>
 
+#include <cstdint> // std::uint8_t
+
 namespace sourcemeta::core {
 
 /// @ingroup alterschema
 /// The category of a built-in transformation rule
-enum class AlterSchemaMode {
+enum class AlterSchemaMode : std::uint8_t {
   /// Rules that simplify the given schema for both human readability and
   /// performance
   Readability,

src/extension/alterschema/linter/draft_official_dialect_without_empty_fragment.h

@@ -39,6 +39,6 @@ class DraftOfficialDialectWithoutEmptyFragment final
   auto transform(sourcemeta::core::JSON &schema) const -> void override {
     auto schema_value = schema.at("$schema").to_string();
     schema_value += "#";
-    schema.at("$schema").into(sourcemeta::core::JSON{std::move(schema_value)});
+    schema.at("$schema").into(sourcemeta::core::JSON{schema_value});
   }
 };

src/extension/alterschema/linter/modern_official_dialect_with_empty_fragment.h

@@ -31,6 +31,6 @@ class ModernOfficialDialectWithEmptyFragment final
   auto transform(sourcemeta::core::JSON &schema) const -> void override {
     auto schema_value = schema.at("$schema").to_string();
     schema_value.pop_back();
-    schema.at("$schema").into(sourcemeta::core::JSON{std::move(schema_value)});
+    schema.at("$schema").into(sourcemeta::core::JSON{schema_value});
   }
 };