-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Brain Dump #11
Comments
(I numbered your comment to make it easier to reply)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Already sorry for the mess, but it is hard for some information to find the correct place. This is why I dump it here (before I forget it), some parts might also need to be discussed.
General map info
General game experience
viewbox should be specified in section 1018 and 1019 (see PR) and the screen resolution
I am quite sure that game speed is not saved (or at least it gets ignored), as in Single-Player, a game always starts with the players current speed and in multiplayer, the game starts with game speed 40 (game speeds are adjustable with the UCP)
zoom level is probably saved (at least for the scenario editor) per session, and not in the map file. same seems to be true for the flattened view
Map orientation is saved in section 1044
It might be useful to split shc_data.CT in multiple lua files and work with imports as I updated the stuff in my repo. It's hard to find stuff in a single large file. Maybe also add a file where all the section offsets are at runtime?
It is kinda hard find stuff in the repo (like (this)[https://github.com/sourcehold/sourcehold-maps/blob/master/sourcehold/maps/init.py] and (this)[https://github.com/sourcehold/sourcehold-maps/blob/f8c6914dc89bacada9aa6ffc928b3b222fd512cf/sourcehold/maps/sections/init.py], which would have saved me a lot of time if I had found it earlier, I find myself reinventing stuff regularly, only to find it at some point somewhere in the repo). Some restructuring (plus some documentation) would be amazing.
One easy refactoring would be to merge the folders (structure)[https://github.com/sourcehold/sourcehold-maps/tree/master/structure], (documentation)[https://github.com/sourcehold/sourcehold-maps/tree/master/documentation] and cheatengine (only the structures) like this:
structure/kaitai
structure/cheatengine
When I am done, I can add my construct definition to structure/construct (there are still some unresolved problems, unfortunately, but I am working on it) and put the *.CT file into a folder like process_inspection (In analogue to file_inspection).
Cheers!
The text was updated successfully, but these errors were encountered: