Remove repo-updater container (#1202)

Sister PR of sourcegraph/deploy-sourcegraph-helm#671.

Upgrade info alert is at sourcegraph/docs#1110.

The repo-updater service is no longer required starting with Sourcegraph
6.4.

Test plan: Repo-updater-less instances have been running for a while
now.


### Checklist

<!--
Kubernetes and Docker Compose MUST be kept in sync. You should not merge
a change here
without a corresponding change in the other repository, unless it truly
is specific to
this repository. If uneeded, add link or explanation of why it is not
needed here.
-->
* [x] Sister
[deploy-sourcegraph](https://github.com/sourcegraph/deploy-sourcegraph)
change: sourcegraph/deploy-sourcegraph#4468
* [x] Sister
[customer-replica](https://github.com/sourcegraph/deploy-sourcegraph-docker-customer-replica-1)
change (if necessary, for any changes affecting pure-docker or
configuration):
sourcegraph/deploy-sourcegraph-docker-customer-replica-1#79
* [ ] All images have a valid tag and SHA256 sum

Author: eseliger

docker-compose/docker-compose.yaml

@@ -139,7 +139,6 @@ services:
       - 'SYMBOLS_URL=http://symbols-0:3184'
       - 'INDEXED_SEARCH_SERVERS=zoekt-webserver-0:6070'
       - 'SRC_FRONTEND_INTERNAL=sourcegraph-frontend-internal:3090'
-      - 'REPO_UPDATER_URL=http://repo-updater:3182'
       - 'GRAFANA_SERVER_URL=http://grafana:3370'
       - 'PROMETHEUS_URL=http://prometheus:9090'
       - 'PRECISE_CODE_INTEL_UPLOAD_BACKEND=blobstore'
@@ -152,7 +151,6 @@ services:
             { "Name": "gitserver-0", "Host": "gitserver-0:6060" },
             { "Name": "searcher-0", "Host": "searcher-0:6060" },
             { "Name": "symbols-0", "Host": "symbols-0:6060" },
-            { "Name": "repo-updater", "Host": "repo-updater:6060" },
             { "Name": "worker", "Host": "worker:6060" },
             { "Name": "zoekt-indexserver-0", "Host": "zoekt-indexserver-0:6072" },
             { "Name": "zoekt-webserver-0", "Host": "zoekt-webserver-0:6070", "DefaultPath": "/debug/requests/" }
@@ -194,7 +192,6 @@ services:
       - 'SYMBOLS_URL=http://symbols-0:3184'
       - 'INDEXED_SEARCH_SERVERS=zoekt-webserver-0:6070'
       - 'SRC_FRONTEND_INTERNAL=sourcegraph-frontend-internal:3090'
-      - 'REPO_UPDATER_URL=http://repo-updater:3182'
       - 'GRAFANA_SERVER_URL=http://grafana:3000'
       - 'PROMETHEUS_URL=http://prometheus:9090'
       - 'PRECISE_CODE_INTEL_UPLOAD_BACKEND=blobstore'
@@ -342,26 +339,6 @@ services:
       - sourcegraph
     restart: always
 
-  # Description: Handles repository metadata (not Git data) lookups and updates from external code hosts and other similar services.
-  #
-  # Disk: 128GB / non-persistent SSD
-  # Ports exposed to other Sourcegraph services: 3182/TCP 6060/TCP
-  # Ports exposed to the public internet: none
-  #
-  repo-updater:
-    container_name: repo-updater
-    image: 'index.docker.io/sourcegraph/repo-updater:6.1.2889@sha256:95e8a28bd2d13270a5d0ab80eae5e8aac44913bd421fb92cf45d5550c4874fbc'
-    cpus: 4
-    mem_limit: '4g'
-    environment:
-      - 'SRC_FRONTEND_INTERNAL=sourcegraph-frontend-internal:3090'
-      - 'OTEL_EXPORTER_OTLP_ENDPOINT=http://otel-collector:4317'
-    volumes:
-      - 'repo-updater:/mnt/cache'
-    networks:
-      - sourcegraph
-    restart: always
-
   # Description: Manages background processes.
   #
   # Disk: 128GB / non-persistent SSD
@@ -802,7 +779,6 @@ volumes:
   prometheus-v2:
   redis-cache:
   redis-store:
-  repo-updater:
   worker:
   searcher-0:
   sourcegraph-frontend-0:

prometheus/prometheus_targets.yml

@@ -5,11 +5,6 @@
   targets:
     - cadvisor:48080
     - sourcegraph-frontend-internal:6060
-- labels:
-    nodename: "sourcegraph-docker-compose-host"
-    job: repo-updater
-  targets:
-    - repo-updater:6060
 - labels:
     nodename: "sourcegraph-docker-compose-host"
     job: worker

pure-docker/deploy-frontend-internal.sh

@@ -34,7 +34,6 @@ docker run --detach \
     -e SYMBOLS_URL="$(addresses "http://symbols-" $NUM_SYMBOLS ":3184")" \
     -e INDEXED_SEARCH_SERVERS="$(addresses "zoekt-webserver-" $NUM_INDEXED_SEARCH ":6070")" \
     -e SRC_FRONTEND_INTERNAL=sourcegraph-frontend-internal:3090 \
-    -e REPO_UPDATER_URL=http://repo-updater:3182 \
     -e GRAFANA_SERVER_URL=http://grafana:3000 \
     -e PROMETHEUS_URL=http://prometheus:9090 \
     -e PRECISE_CODE_INTEL_UPLOAD_BACKEND=blobstore \

pure-docker/deploy-frontend.sh

@@ -35,7 +35,6 @@ docker run --detach \
     -e SYMBOLS_URL="$(addresses "http://symbols-" $NUM_SYMBOLS ":3184")" \
     -e INDEXED_SEARCH_SERVERS="$(addresses "zoekt-webserver-" $NUM_INDEXED_SEARCH ":6070")" \
     -e SRC_FRONTEND_INTERNAL=sourcegraph-frontend-internal:3090 \
-    -e REPO_UPDATER_URL=http://repo-updater:3182 \
     -e GRAFANA_SERVER_URL=http://grafana:3370 \
     -e PROMETHEUS_URL=http://prometheus:9090 \
     -e PRECISE_CODE_INTEL_UPLOAD_BACKEND=blobstore \

pure-docker/deploy-repo-updater.sh

@@ -22,7 +22,6 @@ for i in $(seq 0 $(($NUM_GITSERVER - 1))); do ./deploy-gitserver.sh $i; done
 ./deploy-prometheus.sh
 ./deploy-redis-cache.sh
 ./deploy-redis-store.sh
-./deploy-repo-updater.sh
 ./deploy-worker.sh
 ./deploy-otel-collector.sh
 for i in $(seq 0 $(($NUM_SEARCHER - 1))); do ./deploy-searcher.sh $i; done

pure-docker/deploy.sh

@@ -23,7 +23,6 @@ docker rm -f migrator &>/dev/null || true &
 docker rm -f prometheus &>/dev/null || true
 docker rm -f redis-cache &>/dev/null || true &
 docker rm -f redis-store &>/dev/null || true &
-docker rm -f repo-updater &>/dev/null || true &
 docker rm -f worker &>/dev/null || true &
 docker rm -f $(addresses "searcher-" $NUM_SEARCHER "") &>/dev/null || true &
 docker rm -f $(addresses "symbols-" $NUM_SYMBOLS "") &>/dev/null || true &

pure-docker/teardown.sh

@@ -12,10 +12,10 @@ deploy_sourcegraph() {
 	if [[ "$TEST_TYPE" == "pure-docker-test" ]]; then
 		./test/volume-config.sh
 		timeout 600s ./pure-docker/deploy.sh
-		expect_containers="25"
+		expect_containers="24"
 	elif [[ "$TEST_TYPE" == "docker-compose-test" ]]; then
 		docker-compose --file docker-compose/docker-compose.yaml up -d -t 600
-		expect_containers="27"
+		expect_containers="26"
 	fi
 
 	echo "Giving containers 90s to start..."

test/smoke-test.sh

@@ -18,7 +18,7 @@ echo
 echo "forcing static permissions on volume directories"
 echo
 pushd ~/sourcegraph-docker
-chown -R 100:101 gitserver* prometheus-v2* worker* repo-updater* searcher* sourcegraph-frontend* symbols* zoekt* blobstore-disk
+chown -R 100:101 gitserver* prometheus-v2* worker* searcher* sourcegraph-frontend* symbols* zoekt* blobstore-disk
 chown -R 999:1000 redis-store-disk redis-cache-disk
 chown -R 472:472 grafana-disk
 chown -R 999:999 pgsql-disk codeintel-db-disk