Remove src/interpreter/interpreter.ts

[martin-henz]

I think src/ec-evaluator is replacing src/interpreter/interpreter.ts, so the latter is dead code.

Background: The interpreter used to be the workhorse implementation in SA, prior to the transpiler. After the transpiler was introduced, it became the implementation behind the environment visualizer. Now the environment visualizer uses ec-evaluator, which means that the interpreter is unemployed.

I suggest we should remove src/interpreter/interpreter.ts from js-slang, and leave some breadcrumbs in the wiki. It is bound to decay over time and cause extra work.

See also #1695

[RichDom2185]

I think we should proceed with the removal. The only references to src/interpreter/interpreter.ts are as follows:

• js-slang/src/interpreter/closure.ts

  Lines 15 to 20 in 9b48944

  	import { apply } from './interpreter'
  	const closureToJS = (value: Closure, context: Context, klass: string) => {
  	function DummyClass(this: Closure) {
  	const args: Value[] = Array.prototype.slice.call(arguments)
  	const gen = apply(context, value, args, callExpression(identifier(klass), args), this)

• js-slang/src/runner/sourceRunner.ts

  Lines 115 to 127 in 9b48944

  	function runInterpreter(program: es.Program, context: Context, options: IOptions): Promise<Result> {
  	let it = evaluate(program, context, true, true)
  	let scheduler: Scheduler
  	if (context.variant === Variant.NON_DET) {
  	it = nonDetEvaluate(program, context)
  	scheduler = new NonDetScheduler()
  	} else if (options.scheduler === 'async') {
  	scheduler = new AsyncScheduler()
  	} else {
  	scheduler = new PreemptiveScheduler(options.steps)
  	}
  	return scheduler.run(it, context)
  	}

• js-slang/src/mocks/context.ts

  Line 5 in 9b48944

  import { createBlockEnvironment } from '../interpreter/interpreter'

  Perhaps we can just replace this with

  import { createBlockEnvironment } from '../ec-evaluator/utils'

How are would it be to completely remove it?

[martin-henz]

I think we should completely remove it. It's a confusing legacy component at this point. Where are these "mocks" used?

[RichDom2185]

I think we should completely remove it. It's a confusing legacy component at this point. Where are these "mocks" used?

The mocks in the last bullet point are used in test files. I'll make a PR with the necessary changes.

[leeyi45]

Resolved by #1745