Update testing utilities

Author: leeyi45

src/parser/errors.ts

@@ -1,7 +1,7 @@
-import { SourceLocation } from 'estree'
+import type { SourceLocation } from 'estree'
 
 import { UNKNOWN_LOCATION } from '../constants'
-import { ErrorSeverity, ErrorType, Node, SourceError } from '../types'
+import { ErrorSeverity, ErrorType, type Node, type SourceError } from '../types'
 import { stripIndent } from '../utils/formatters'
 
 export class MissingSemicolonError implements SourceError {

src/parser/types.ts

@@ -1,11 +1,9 @@
-import { ParserOptions } from '@babel/parser'
-import { Options } from 'acorn'
-import { Program } from 'estree'
+import type { Program } from 'estree'
 
 import { Context, type Chapter, type Node, type SourceError, type Variant } from '../types'
 
-export type AcornOptions = Options
-export type BabelOptions = ParserOptions
+export type { Options as AcornOptions } from 'acorn'
+export type { ParserOptions as BabelOptions } from '@babel/parser'
 
 export interface Parser<TOptions> {
   parse(
@@ -27,8 +25,9 @@ export interface Rule<T extends Node> {
   testSnippets?: (
     | [code: string] // Test case with no expected error
     | [code: string, errorMsg: string] // Test case with expected error message
+    // Test both expected error verbose and non-verbose
     | [code: string, errorMsg: string, verboseMsg: string]
-  )[] // Test both expected error verbose and non-verbose
+  )[]
   checkers: {
     [name: string]: (node: T, ancestors: Node[]) => SourceError[]
   }

src/parser/utils.ts

@@ -1,20 +1,20 @@
 import {
-  Comment,
+  type Comment,
   ecmaVersion,
-  Node,
+  type Node,
   parse as acornParse,
   parseExpressionAt as acornParseAt,
-  Position
+  type Position
 } from 'acorn'
 import { parse as acornLooseParse } from 'acorn-loose'
-import { Program, SourceLocation } from 'estree'
+import type { Program, SourceLocation } from 'estree'
 
-import { Context } from '..'
+import type { Context } from '..'
 import { DEFAULT_ECMA_VERSION } from '../constants'
-import { SourceError } from '../types'
+import type { SourceError } from '../types'
 import { validateAndAnnotate } from '../validator/validator'
 import { MissingSemicolonError, TrailingCommaError } from './errors'
-import { AcornOptions, BabelOptions } from './types'
+import type { AcornOptions, BabelOptions } from './types'
 
 /**
  * Generates options object for acorn parser

src/utils/testing/__tests__/testing.ts

@@ -24,7 +24,7 @@ describe('Testing createTestContext', () => {
     expect(context.variant).toEqual(Variant.DEFAULT)
   })
 
-  test('Providing a chaper runs default variant and that chapter', () => {
+  test('Providing a chapter runs default variant and that chapter', () => {
     const context = createTestContext(Chapter.SOURCE_3)
     expect(context.chapter).toEqual(Chapter.SOURCE_3)
     expect(context.variant).toEqual(Variant.DEFAULT)

src/utils/testing/index.ts

@@ -6,12 +6,7 @@ import { mockContext } from './mocks'
 import type { TestContext, TestOptions, TestResults } from './types'
 
 export function createTestContext(rawOptions: TestOptions = {}): TestContext {
-  const { chapter, variant, testBuiltins }: Exclude<TestOptions, Chapter> =
-    typeof rawOptions === 'number'
-      ? {
-          chapter: rawOptions
-        }
-      : rawOptions
+  const { chapter, variant, testBuiltins } = processTestOptions(rawOptions)
 
   const testContext: TestResults = {
     displayResult: [],
@@ -68,8 +63,7 @@ export function testMultipleCases<T extends Array<any>>(
   test.each(withIndex)('%s', (_, i, ...args) => tester(args, i), timeout)
 }
 
-async function testInContext(code: string, rawOptions: TestOptions) {
-  const options = processTestOptions(rawOptions)
+async function testInContext(code: string, options: TestOptions) {
   const context = createTestContext(options)
   const result = await runInContext(code, context)
   return {