Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms Without Autocomplete Prevention on 3 pages #298

Open
sourabhkatti opened this issue Jul 18, 2018 · 0 comments
Open

Forms Without Autocomplete Prevention on 3 pages #298

sourabhkatti opened this issue Jul 18, 2018 · 0 comments

Comments

@sourabhkatti
Copy link
Owner

Trace UUID: P7M8-2H4O-S7L4-HT3R

https://apptwo.contrastsecurity.com/Contrast/static/ng/index.html#/f7ea7169-d4eb-42c4-b32e-5c0ea0ca9733/vulns/P7M8-2H4O-S7L4-HT3R/overview

Description

We observed 3 pages which contained form elements that did not have autocomplete set to off:

/WebGoat/login
/WebGoat/HttpBasics.lesson.lesson
/WebGoat/CrossSiteScripting.lesson.lesson

Risk

Any <form> tags without the autocomplete attribute set to off allow user
agents to automatically save user credentials. Even if individual fields have autocomplete
disabled, it is a safer practice to cover the entire <form>.

Recommendation to fix this finding

Disabling autocomplete on form values is easy. All you have to do is add an autocomplete attribute
with a setting of off, as is shown in the password field of this example:

<form action="/login" "method="POST">
<input type="text" name="username">
<input type="password" name="userpass" autocomplete="off">
</form>

However, to prevent Contrast from flagging the form, you should disable autocomplete on the entire
&lt;form&gt;, as shown here:

<form action="/login" "method="POST" autocomplete="off">
<input type="text" name="username">
<input type="password" name="userpass">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant