Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request info in README is out of date? #433

Open
jamesf-carallon opened this issue Feb 21, 2025 · 3 comments
Open

Pull request info in README is out of date? #433

jamesf-carallon opened this issue Feb 21, 2025 · 3 comments

Comments

@jamesf-carallon
Copy link

Hello. I can see in the pull requests section that PRs have been accepted from various sources (I'm guessing not just within Sony). But in the README it says

Now, we cannot accept any Pull Request (PR). Because We are building a system (e.g. CLA) to accept PRs, so please wait for a while the system is getting ready! However, we are always welcome to report bugs and request new features by creating issues.

With the assumption, our final goal of this software openly is to be merged this embedder into Flutter Engine after getting feedbacks. And Google CLA will be required when we do that in the future. Therefore, we cannot easily accept an external PR. However, you can free to create issues for reporting bugs and requesting new features.

Please could you provide clarity on whether PRs are welcome?

@HidenoriMatsubayashi
Copy link
Contributor

@taka-okayama

@taka-okayama
Copy link
Contributor

@jamesf-carallon @HidenoriMatsubayashi
Sorry, let me check the PR policy.
However, at this time, we would appreciate it if you could follow the wording in README.md.

@jamesf-carallon
Copy link
Author

@taka-okayama
Thank you for getting back to me. I have an implementation of software rendering (#287), which I'm tidying up and soon will be suitable for a PR, if you guys would like it. If your policy changes and PRs become welcome, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants