Fix health check for SSD vendors: add a parser for ATP, and add a generic health ID for other brands (#595)

Description
Fix health check for SSD vendors: add a parser for ATP, and add a generic health ID for other brands.
Each vendor stores health information in different SMART attributes.
ATP stores it in attribute ID 248, we add a parser for it.
We also have SSDs use Attribute ID 231 and it is commonly used, so add it in the generic parser.
Skip obtaining vendor SSD info for ATP and Virtium NVMe SSD because they are handle by parse_generic_ssd_info and parse_vendor_ssd_info will overwrite data with N/A.
Add unit test cases for ATP SATA/NVMe SSD.

Motivation and Context
show platform ssdhealth shows N/A health for some qualified SSDs.

Back port request
 202412
 202505
How Has This Been Tested?
We have tested the code change on DUTs with different SSDs including all the qualified SSDs that show N/A in health and also on the ones that worked fine before.

Author: markx-arista

sonic_platform_base/sonic_storage/ssd.py

@@ -25,7 +25,7 @@
 
 # Generic IDs
 
-GENERIC_HEALTH_ID = 169
+GENERIC_HEALTH_ID = [169, 231]
 GENERIC_IO_READS_ID = 242
 GENERIC_IO_WRITES_ID = 241
 GENERIC_RESERVED_BLOCKS_ID = [170, 232]
@@ -53,6 +53,8 @@
 
 INTEL_MEDIA_WEAROUT_INDICATOR_ID = 233
 
+ATP_HEALTH_ID = 248
+
 class SsdUtil(StorageCommon):
     """
     Generic implementation of the SSD health API
@@ -85,6 +87,7 @@ def __init__(self, diskdev):
             "Micron"            : { "utility" : SMARTCTL, "parser" : self.parse_micron_info },
             "Intel"             : { "utility" : SMARTCTL, "parser" : self.parse_intel_info },
             "Transcend"         : { "utility" : SMARTCTL, "parser" : self.parse_generic_ssd_info },
+            "ATP"               : { "utility" : SMARTCTL, "parser" : self.parse_atp_info },
         }
 
         self.dev = diskdev
@@ -100,12 +103,12 @@ def fetch_parse_info(self, diskdev):
 
         # Known vendor part
         if self.model:
-            # For some Virtium SSDs, parse_generic_ssd_info should be called.
-            # Since it was called above, no need to parse a specific vendor SSD info.
-            if self.model in ['Virtium VTPM24CEXI080-BM110006']:
+            vendor = self._parse_vendor()
+            # For Virtium, ATP NVMe SSD, parse_generic_ssd_info should be called.
+            # Skip here, otherwise data will be overwritten by N/A.
+            if vendor in ['Virtium', 'ATP'] and "nvme" in self.dev:
                 return
 
-            vendor = self._parse_vendor()
             if vendor:
                 try:
                     self.fetch_vendor_ssd_info(diskdev, vendor)
@@ -189,10 +192,11 @@ def parse_generic_ssd_info(self):
 
             health_raw = self._parse_re('Remaining_Lifetime_Perc\s*(.+?)\n', self.ssd_info)
             if health_raw == NOT_AVAILABLE:
-                health_raw = self.parse_id_number(GENERIC_HEALTH_ID, self.ssd_info)
-                if health_raw == NOT_AVAILABLE:
-                    self.health = NOT_AVAILABLE
-                else: self.health = health_raw.split()[-1]
+                for health_id in GENERIC_HEALTH_ID:
+                    health_raw = self.parse_id_number(health_id, self.ssd_info)
+                    if health_raw != NOT_AVAILABLE:
+                        break
+                self.health = NOT_AVAILABLE if health_raw == NOT_AVAILABLE else health_raw.split()[-1]
             else:
                 self.health = health_raw.split()[-1]
 
@@ -359,6 +363,11 @@ def parse_intel_info(self):
             health_raw = self.parse_id_number(INTEL_MEDIA_WEAROUT_INDICATOR_ID, self.vendor_ssd_info)
             self.health = NOT_AVAILABLE if health_raw == NOT_AVAILABLE else str(100 - float(health_raw.split()[-1]))
 
+    def parse_atp_info(self):
+        if self.vendor_ssd_info:
+            health_raw = self.parse_id_number(ATP_HEALTH_ID, self.vendor_ssd_info)
+            self.health = NOT_AVAILABLE if health_raw == NOT_AVAILABLE else health_raw.split()[-1]
+
     def fetch_vendor_ssd_info(self, diskdev, model):
         self.vendor_ssd_info = self._execute_shell(self.vendor_ssd_utility[model]["utility"].format(diskdev))