Entry Point Contradiction for withdraw_refund

[hman38705]

Description
The withdraw_refund function exists in both cancellation.rs and bets.rs with slightly different signatures and logic (e.g., SAC safety). This creates two entry points for the same logical operation, leading to confusion for developers and potentially allowing a user to double-refund if the state removal isn't perfectly synchronized across both paths.

Requirements and context

• Consolidate all refund logic into a single internal utility or a dedicated module.
• Ensure only one public entry point exists for user refunds.

Suggested execution

• Fork the repo and create a branch: git checkout -b refactor/issue-92-refund-unification
• Deprecate the redundant function.

Implementation changes

• Move the primary refund logic to bets.rs and update cancellation.rs to call it, or remove one entirely.

Test and commit

• Verify that a user cannot successfully call both refund functions for the same bet.

Example commit message
refactor: unify market refund entry points to prevent duplication and double-spend risks

Guidelines

• Modular clear design.
• Timeframe: 24 hours.

[muhahahmad68]

@muhahahmad68 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Kindly assign his issue to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @muhahahmad68 to this issue.

[chidinma000]

@chidinma000 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

i will like to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @chidinma000 to this issue.

[drips-wave]

Congratulations, @chidinma000! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @chidinma000: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @chidinma000 as part of the Stellar Wave Program's 3rd Wave 🥳

😎 @chidinma000: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.