-
Notifications
You must be signed in to change notification settings - Fork 46
Closed
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave program
Description
Description
The function get_creation_deposit (Line 196) and its setter (Line 203) use ConfigKey::CreationDeposit directly as a storage key. In Soroban, enums used as keys in instance or persistent storage must be properly handled to avoid collisions with other instance variables or metadata. Using a raw enum variant as a top-level key without a formal wrapping structure is poor practice and risky.
Requirements and context
- Formalize the storage key structure for all configuration parameters.
- Ensure no collisions with other data types in the instance storage.
Suggested execution
- Fork the repo and create a branch:
git checkout -b fix/issue-81-config-keys - Refactor the configuration storage pattern.
Implementation changes
- Update
markets.rs(Line 199 & 207) to use a consistentDataKey::Config(ConfigKey)pattern.
Test and commit
- Verify that setting the creation deposit does not overwrite other persistent counters like
MarketCount.
Example commit message
fix: use structured DataKey for configuration storage to avoid collisions
Guidelines
- Storage safety.
- Timeframe: 12 hours.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave program