Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content] Improve documentation on deferStream #987

Open
mileung opened this issue Dec 17, 2024 · 6 comments
Open

[content] Improve documentation on deferStream #987

mileung opened this issue Dec 17, 2024 · 6 comments
Labels
good first issue Good for newcomers help wanted Looking for assistance on this issue solid-router Related to Solid Router

Comments

@mileung
Copy link

mileung commented Dec 17, 2024

as in

const user = createAsync(() => getUser(), { deferStream: true });
@mileung
Copy link
Author

mileung commented Dec 17, 2024

also missing in the docs search is RouteDefinition as in

export const route = {
	preload() {
		getUser();
	},
} satisfies RouteDefinition;

@amirhhashemi
Copy link
Collaborator

amirhhashemi commented Feb 14, 2025

@mileung I'm not entirely sure what the issue is. If you’re referring to the fact that searching for "deferStream" in the site’s search bar doesn’t display the items you mentioned, that is intentional. We do not include code blocks in the search results to avoid cluttering them.

I will go ahead and close this issue. However, if I misunderstood anything, please feel free to reopen it.

@mileung
Copy link
Author

mileung commented Feb 16, 2025

I thought it would be appropriate for a related link like this to show up when you search for deferStream.

Image

@amirhhashemi
Copy link
Collaborator

Oh, that's a problem. We will address it soon.

@amirhhashemi amirhhashemi reopened this Feb 17, 2025
@atilafassina atilafassina added good first issue Good for newcomers help wanted Looking for assistance on this issue planned Features or content that are planned but not yet in progress. solid-router Related to Solid Router labels Feb 20, 2025
@atilafassina atilafassina changed the title [Search] Missing results for query "deferStream" [content] Improve documentation on deferStream Feb 20, 2025
@atilafassina
Copy link
Member

Imho, the solution should be as simple as adding proper documentation to deferStream so Orama can index it. Right now it's mention very briefly in the references table.

@amirhhashemi / @LadyBluenotes

@amirhhashemi
Copy link
Collaborator

@atilafassina IMHO, the reference page is the proper place to document deferStream. We should avoid duplicating documentation.

I propose a structural change, shifting from a table format to this layout:

## Options

### `deferStream`

**Type:** `boolean`

Description...

This change should resolve the current issue and also provide an opportunity to include additional information about a prop or option, such as examples that couldn't be housed in a table format.

@LadyBluenotes LadyBluenotes removed the planned Features or content that are planned but not yet in progress. label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Looking for assistance on this issue solid-router Related to Solid Router
Projects
None yet
Development

No branches or pull requests

4 participants