Skip to content

Commit 83ca23a

Browse files
amirhhashemikodiakhq[bot]LadyBluenotes
authored
Improve accessibility (#1122)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Sarah <[email protected]>
1 parent 0ee083f commit 83ca23a

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

src/ui/callout.tsx

+5
Original file line numberDiff line numberDiff line change
@@ -40,30 +40,35 @@ const styles = {
4040
const icons = {
4141
tip: (props: { class?: string }) => (
4242
<Icon
43+
aria-hidden="true"
4344
path={lightBulb}
4445
class={`${props.class} fill-violet-900 dark:fill-violet-300`}
4546
/>
4647
),
4748
info: (props: { class?: string }) => (
4849
<Icon
50+
aria-hidden="true"
4951
path={bookOpen}
5052
class={`${props.class} fill-emerald-800 dark:fill-emerald-300`}
5153
/>
5254
),
5355
advanced: (props: { class?: string }) => (
5456
<Icon
57+
aria-hidden="true"
5558
path={puzzlePiece}
5659
class={`${props.class} fill-blue-700 dark:fill-blue-300`}
5760
/>
5861
),
5962
caution: (props: { class?: string }) => (
6063
<Icon
64+
aria-hidden="true"
6165
path={exclamationTriangle}
6266
class={`${props.class} fill-amber-500 dark:fill-amber-400`}
6367
/>
6468
),
6569
danger: (props: { class?: string }) => (
6670
<Icon
71+
aria-hidden="true"
6772
path={xCircle}
6873
class={`${props.class} fill-red-500 dark:fill-red-400`}
6974
/>

src/ui/edit-page-link.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const EditPageLink: Component = () => {
1717
href={editLink()}
1818
target="_blank"
1919
>
20-
<Icon class="mr-1 w-[16px]" path={pencilSquare} />
20+
<Icon aria-hidden="true" class="mr-1 w-[16px]" path={pencilSquare} />
2121
{i18n.t("contribute.edit")}
2222
</a>
2323
)}

src/ui/layout/main-navigation.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ function DirList(props: { list: Entry[]; sortAlphabeticaly?: boolean }) {
105105
{child.title}
106106
</span>
107107
<Icon
108+
aria-hidden="true"
108109
path={chevronDown}
109110
class="h-4 my-auto transition-transform kb-group-closed:rotate-180"
110111
/>

src/ui/quick-links.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ export const QuickLinks: ParentComponent<QuickLinksProps> = (props) => {
3030
<div class="absolute -inset-px rounded-xl border-2 border-transparent opacity-0 [background:linear-gradient(var(--quick-links-hover-bg,theme(colors.sky.200)),var(--quick-links-hover-bg,theme(colors.sky.200)))_padding-box,linear-gradient(to_top,theme(colors.indigo.400),theme(colors.cyan.400),theme(colors.sky.500))_border-box] group-hover:opacity-100 dark:[--quick-links-hover-bg:theme(colors.slate.800)]" />
3131
<div class="relative overflow-hidden rounded-xl px-5 py-4">
3232
<div class="flex items-center">
33-
<Icon path={icons[props.icon as keyof typeof icons]} class="h-7 w-7 fill-blue-500" />
33+
<Icon
34+
aria-hidden="true"
35+
path={icons[props.icon as keyof typeof icons]}
36+
class="h-7 w-7 fill-blue-500"
37+
/>
3438
<div class="text-xl text-slate-900 dark:text-white capitalize no-underline pl-3">
3539
<Show
3640
when={isExternalURL(props.href)}

0 commit comments

Comments
 (0)