fix: clean up linting errors

Author: danieljcafonso

.eslintrc.json

@@ -28,6 +28,18 @@
 	"plugins": ["@typescript-eslint", "solid"],
 	"rules": {
 		"quotes": ["error", "double"],
-		"semi": "warn"
+		"semi": "warn",
+		"@typescript-eslint/no-unused-vars": [
+			"error",
+			{
+				"args": "all",
+				"argsIgnorePattern": "^_",
+				"caughtErrors": "all",
+				"caughtErrorsIgnorePattern": "^_",
+				"destructuredArrayIgnorePattern": "^_",
+				"varsIgnorePattern": "^_",
+				"ignoreRestSiblings": true
+			}
+		]
 	}
 }

app.config.ts

@@ -58,6 +58,7 @@ export default defineConfig({
 			crawlLinks: true,
 			autoSubfolderIndex: false,
 			failOnError: true,
+			// eslint-disable-next-line no-useless-escape
 			ignore: [/\{\getPath}/, /.*?emojiSvg\(.*/],
 		},
 	},

src/data/get-nav.tsx

@@ -1,4 +1,4 @@
-import matter, { GrayMatterFile } from "gray-matter";
+import { GrayMatterFile } from "gray-matter";
 
 export type Section = {
 	type: "section";

src/data/page-state.tsx

@@ -1,5 +1,5 @@
-import { createEffect, createContext, ParentProps, useContext } from "solid-js";
-import { SetStoreFunction, StoreSetter, createStore } from "solid-js/store";
+import { createContext, ParentProps, useContext } from "solid-js";
+import { SetStoreFunction, createStore } from "solid-js/store";
 
 type ChildSection = {
 	text: string | undefined;

src/data/theme-provider.tsx

@@ -36,8 +36,8 @@ function getCookie(name: string, cookieString: string) {
 const ThemeCtx = createContext<ThemeContext>();
 const getUserTheme = () => {
 	if (isServer) {
-		const e = getRequestEvent();
-		return getCookie("theme", e?.request.headers.get("cookie")!);
+		const e = getRequestEvent()!;
+		return getCookie("theme", e.request.headers.get("cookie")!);
 	}
 	return getCookie("theme", document.cookie);
 };

src/i18n/dictionaries/index.ts

@@ -1,5 +1,5 @@
 import english from "./en/ui";
-import ptbr from "./pt-br/ui";
+// import ptbr from "./pt-br/ui";
 
 export const dictionaries = {
 	default: english,

src/i18n/helpers.ts

@@ -1,18 +1,14 @@
-import { useLocation, useMatch } from "@solidjs/router";
+import { useLocation } from "@solidjs/router";
 import { SUPPORTED_LOCALES } from "./config";
 import { useCurrentRouteMetaData } from "~/utils/route-metadata-helper";
 
-
 export function getLocaleFromPathname(pathname: string) {
 	return pathname.split("/")[1];
 }
 
 export function isValidLocale(
 	locale: string
 ): locale is (typeof SUPPORTED_LOCALES)[number] {
-	// TS is being annoying.
-	// we are actually narrowing string here.
-	// @ts-ignore
 	return SUPPORTED_LOCALES.includes(locale);
 }
 
@@ -22,7 +18,6 @@ export function getValidLocaleFromPathname(pathname: string) {
 	return isValidLocale(locale) ? locale : null;
 }
 
-
 export function getEntryFileName() {
 	const pathname = useLocation().pathname;
 	const currentRouteMetaData = useCurrentRouteMetaData();

src/i18n/translator.ts

@@ -4,11 +4,11 @@ import { SUPPORTED_LOCALES } from "./config";
 export function createTranslator(
 	locale: (typeof SUPPORTED_LOCALES)[number] | null
 ) {
+	// type overlap will only be 100% when translations are done
+	// so we're fine with `dictionaries[locale][key]` being implicit `any`
+	// @ts-expect-error: expected any here
 	const dictionary = dictionaries[locale || "default"];
 	return (key: keyof (typeof dictionaries)["default"]) => {
-		// type overlap will only be 100% when translations are done
-		// so we're fine with `dictionaries[locale][key]` being implicit `any`
-		// @ts-ignore
 		return dictionary[key] || dictionaries["default"][key];
 	};
 }

src/ui/eraser-link/index.tsx

@@ -1,4 +1,5 @@
-import { ParentProps, createSignal } from "solid-js";
+/* eslint-disable solid/reactivity */
+import { ParentProps, Show, createSignal } from "solid-js";
 import "./eraser-link.css";
 
 const ERASER_TRACKING_PARAMS = "";
@@ -28,9 +29,11 @@ const getEraserLinkData = (href: string): EraserLinkData | null => {
 	};
 };
 
-const EraserLink = (props: ParentProps<{
-	linkData: EraserLinkData;
-}>) => {
+const EraserLink = (
+	props: ParentProps<{
+		linkData: EraserLinkData;
+	}>
+) => {
 	const workspaceUrl = `https://app.eraser.io/workspace/${props.linkData.workspaceId}`;
 	const elementParams = props.linkData.elementsId
 		? `elements=${props.linkData.elementsId}`
@@ -43,22 +46,38 @@ const EraserLink = (props: ParentProps<{
 	const [isLoaded, setIsLoaded] = createSignal(false);
 
 	// if there are no children or this was a right click-copy as markdown embed.
-	if (
-		props.children === undefined ||
-		(Array.isArray(props.children) && props.children[0] === "View on Eraser")
-	) {
-		const imageUrl = elementParams
-			? `${workspaceUrl}/preview?${elementParams}&type=embed`
-			: `${workspaceUrl}/preview`;
-
-		return (
+	return (
+		<Show
+			when={
+				props.children === undefined ||
+				(Array.isArray(props.children) &&
+					props.children[0] === "View on Eraser")
+			}
+			fallback={
+				<a
+					href={linkUrl}
+					class="dark:text-solid-darklink break-normal text-solid-lightlink duration-100 ease-in font-semibold leading-normal transition hover:underline"
+					rel="noopener noreferrer"
+				>
+					{props.children}
+				</a>
+			}
+		>
 			<a
 				href={linkUrl}
 				class="relative inline-block"
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				<img src={imageUrl} alt={""} onLoad={() => setIsLoaded(true)} />
+				<img
+					src={
+						elementParams
+							? `${workspaceUrl}/preview?${elementParams}&type=embed`
+							: `${workspaceUrl}/preview`
+					}
+					alt={""}
+					onLoad={() => setIsLoaded(true)}
+				/>
 				{isLoaded() ? (
 					<div class="eraserLinkContainer">
 						<img
@@ -69,31 +88,27 @@ const EraserLink = (props: ParentProps<{
 					</div>
 				) : null}
 			</a>
-		);
-	}
-	return (
-		<a
-			href={linkUrl}
-			class="dark:text-solid-darklink break-normal text-solid-lightlink duration-100 ease-in font-semibold leading-normal transition hover:underline"
-			rel="noopener noreferrer"
-		>
-			{props.children}
-		</a>
+		</Show>
 	);
 };
 
 export default function EraserOrAnchor(props: ParentProps<{ href: string }>) {
 	const eraserLinkData = getEraserLinkData(props.href);
-	if (eraserLinkData) {
-		return <EraserLink linkData={eraserLinkData}>{props.children}</EraserLink>;
-	}
+
 	return (
-		<a
-			{...props}
-			class="dark:text-solid-darklink break-normal text-solid-lightlink duration-100 ease-in font-semibold leading-normal transition hover:underline"
-			rel="noopener noreferrer"
+		<Show
+			when={eraserLinkData !== null}
+			fallback={
+				<a
+					{...props}
+					class="dark:text-solid-darklink break-normal text-solid-lightlink duration-100 ease-in font-semibold leading-normal transition hover:underline"
+					rel="noopener noreferrer"
+				>
+					{props.children}
+				</a>
+			}
 		>
-			{props.children}
-		</a>
+			<EraserLink linkData={eraserLinkData}>{props.children}</EraserLink>
+		</Show>
 	);
 }

src/ui/layout/hero-code-snippet.tsx

@@ -28,5 +28,6 @@ const renderCode = async () => {
 export default function CodeSnippet() {
 	const [code] = createResource(renderCode);
 
+	// eslint-disable-next-line solid/no-innerhtml
 	return <div innerHTML={code()} />;
 }