Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Commit fc97b7d

Browse files
authored
Explain use of nightly clippy over whole monorepo (#31833)
* Explain use of nightly clippy over whole monorepo ref: rust-lang/rust#66287 * Fix typo and update link in test-checks.sh * Incorporate review suggestions
1 parent c0611cb commit fc97b7d

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

ci/test-checks.sh

+8-2
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,13 @@ _ ci/order-crates-for-publishing.py
7777

7878
nightly_clippy_allows=(--allow=clippy::redundant_clone)
7979

80-
# run nightly clippy for `sdk/` as there's a moderate amount of nightly-only code there
80+
# Use nightly clippy, as frozen-abi proc-macro generates a lot of code across
81+
# various crates in this whole monorepo (frozen-abi is enabled only under nightly
82+
# due to the use of unstable rust feature). Likewise, frozen-abi(-macro) crates'
83+
# unit tests are only compiled under nightly.
84+
# Similarly, nightly is desired to run clippy over all of bench files because
85+
# the bench itself isn't stabilized yet...
86+
# ref: https://github.com/rust-lang/rust/issues/66287
8187
_ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy --workspace --all-targets --features dummy-for-ci-check -- \
8288
--deny=warnings \
8389
--deny=clippy::default_trait_access \
@@ -87,7 +93,7 @@ _ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy --workspace -
8793

8894
# temporarily run stable clippy as well to scan the codebase for
8995
# `redundant_clone`s, which is disabled as nightly clippy is buggy:
90-
# https://github.com/rust-lang/rust-clippy/issues/10577
96+
# https://github.com/solana-labs/solana/issues/31834
9197
#
9298
# can't use --all-targets:
9399
# error[E0554]: `#![feature]` may not be used on the stable release channel

0 commit comments

Comments
 (0)