-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Metaplex Core support #431
base: master
Are you sure you want to change the base?
Adding Metaplex Core support #431
Conversation
@blockiosaurus is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for all the hardwork here Keith! Can you provide some sample accounts & screenshots for me to validate? There's some stuff to nit over, but want to get the big stuff done first. |
Sure! Here's a Core collection The Core UI should have the details you need to confirm but let me know if you need anything else! |
Okay the Asset renders great, but the Core collection's address causes the page to crash. Can you help me fix this? I want to write tests for this PR like the ones I added here https://github.com/solana-labs/explorer/blob/master/app/components/instruction/lighthouse/__tests__/LighthouseDetailsCard.test.tsx In order to do this, I need some pages that render correctly. Then I can add tests, make sure things work the way we expect, and then provide feedback on code style etc. FWIW on Asset, I think it would be better to render the Core /metadata section as an actual table instead of a JSON view. It's nicer to be able to hyperlink to owner/delegate etc. Wdyt? |
No description provided.