Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Metaplex Core support #431

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

blockiosaurus
Copy link

No description provided.

Copy link

vercel bot commented Dec 27, 2024

@blockiosaurus is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@ngundotra
Copy link
Collaborator

Thanks for all the hardwork here Keith! Can you provide some sample accounts & screenshots for me to validate?

There's some stuff to nit over, but want to get the big stuff done first.

@blockiosaurus
Copy link
Author

Sure! Here's a Core collection
https://core.metaplex.com/explorer/collection/FfQheiGhS1UcW1JrCFoMcFjWbPt8FqCSyEtFDPTyakNw
And Asset
https://core.metaplex.com/explorer/BhqSq2c9RfqABndNSwk69dqEpWNpXxeporjUP4C221so

The Core UI should have the details you need to confirm but let me know if you need anything else!

@ngundotra
Copy link
Collaborator

Okay the Asset renders great, but the Core collection's address causes the page to crash.

Screenshot 2025-01-03 at 9 48 17 AM

Can you help me fix this?

I want to write tests for this PR like the ones I added here https://github.com/solana-labs/explorer/blob/master/app/components/instruction/lighthouse/__tests__/LighthouseDetailsCard.test.tsx

In order to do this, I need some pages that render correctly. Then I can add tests, make sure things work the way we expect, and then provide feedback on code style etc.

FWIW on Asset, I think it would be better to render the Core /metadata section as an actual table instead of a JSON view. It's nicer to be able to hyperlink to owner/delegate etc. Wdyt?

Screenshot 2025-01-03 at 9 53 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants