hermes init fails with cryptic error message in non-git directory

[zyzzyxdonta]

When running hermes init in a non-git directory, it fails with:

No connection adapters were found for ':///api/v4/version'

This is due to urlparse() not "failing" but rather returning empty strings, here:

hermes/src/hermes/commands/init/base.py

Line 96 in a67e2f9

parsed_url = urlparse(info.git_remote_url)

It might make sense to wrap urlparse() and raise an exception if either of scheme or netloc is not existent. (Or abort searching for git stuff way earlier.)

[poikilotherm]

Closes by now merged #309

[dnlbauer]

@poikilotherm I still see this cryptic message when using hermes init on an empty repository when it does not have an upstream repository set. it would be nice to have a better error message in this case.

Steps to reproduce:

install latest hermes from git

> pipx install git+https://github.com/hermes-hmc/hermes.git

  installed package hermes 0.9.0, installed using Python 3.12.3
  These apps are now globally available
    - hermes
    - hermes-marketplace
done! ✨

create a new git repo and init it with a file

>mkdir -p /tmp/test && cd /tmp/test
>git init
>echo "test" >> testfile.txt
>git add testfile.txt
>git commit -m "add test file"

run hermes init

>hermes init
Run subcommand init

hermes.log file:

1740587078.834470:          hermes.cli:     DEBUG | Running hermes with the following command line arguments: Namespace(subcommand='init', path=PosixPath('.'), config=PosixPath('hermes.toml'), options=[], template_branch='', command=<hermes.commands.init.base.HermesInitCommand object at 0x749c550ae930>)
1740587078.834665:          hermes.cli:     DEBUG | Loading settings...
1740587078.834707:          hermes.cli:     DEBUG | Update settings from command line...
1740587078.834739:          hermes.cli:      INFO | Run subcommand init
1740587078.843297:          hermes.cli:     ERROR | An error occurred during execution of init (Find details in './hermes.log')
1740587078.843416:          hermes.cli:     DEBUG | Original exception was: No connection adapters were found for ':///api/v4/version'

[dnlbauer]

It also happens on an existing project from me that has multiple remotes configured in the git config (i.e. we have projects on our local git as well as github):

steps to reproduce:

git clone https://github.com/dnlbauer/django-signposting
cd django-signplosting
hermes init # this works!

# add second remote
git remote add secondary http://example.com/django-signposting
hermes init # fails

[poikilotherm]

Thanks for reporting back! I'm assigning @nheeb to look into this 😄