Skip to content

Commit fca4caa

Browse files
authored
Merge pull request #38 from mihbor/37
change Option to Optional in javadsl
2 parents 894659b + 390140d commit fca4caa

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

core/src/main/java/com/softwaremill/session/javadsl/HttpSessionAwareDirectives.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
import com.softwaremill.session.SessionContinuity;
77
import com.softwaremill.session.SessionManager;
88
import com.softwaremill.session.SetSessionTransport;
9-
import scala.Option;
109

10+
import java.util.Optional;
1111
import java.util.function.Function;
1212
import java.util.function.Supplier;
1313

@@ -24,7 +24,7 @@ public Route setSession(SessionContinuity sc, SetSessionTransport st, T session,
2424
return SessionDirectives$.MODULE$.setSession(sc, st, session, continuity);
2525
}
2626

27-
public Route optionalSession(SessionContinuity sc, SetSessionTransport st, Function<Option<T>, Route> continuity) {
27+
public Route optionalSession(SessionContinuity sc, SetSessionTransport st, Function<Optional<T>, Route> continuity) {
2828
return SessionDirectives$.MODULE$.optionalSession(sc, st, continuity);
2929
}
3030

core/src/main/java/com/softwaremill/session/javadsl/SessionDirectives.scala

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
package com.softwaremill.session.javadsl
22

3+
import java.util.Optional
34
import java.util.function.Supplier
45

6+
import scala.compat.java8.OptionConverters._
7+
58
import akka.http.javadsl.server.Route
69
import akka.http.javadsl.server.directives.RouteAdapter
710
import com.softwaremill.session._
@@ -23,9 +26,9 @@ trait SessionDirectives extends OneOffSessionDirectives with RefreshableSessionD
2326
}
2427
}
2528

26-
def optionalSession[T](sc: SessionContinuity[T], st: GetSessionTransport, inner: java.util.function.Function[Option[T], Route]): Route = RouteAdapter {
29+
def optionalSession[T](sc: SessionContinuity[T], st: GetSessionTransport, inner: java.util.function.Function[Optional[T], Route]): Route = RouteAdapter {
2730
com.softwaremill.session.SessionDirectives.optionalSession(sc, st) { session =>
28-
inner.apply(session).asInstanceOf[RouteAdapter].delegate
31+
inner.apply(session.asJava).asInstanceOf[RouteAdapter].delegate
2932
}
3033
}
3134

javaTests/src/test/java/com/softwaremill/session/javadsl/HttpSessionAwareDirectivesTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
public abstract class HttpSessionAwareDirectivesTest extends JUnitRouteTest {
4040

4141
static final String SESSION = "my session object";
42-
static final String EXPECTED_SESSION = format("Some(%s)", SESSION);
43-
static final String NO_SESSION = "None";
42+
static final String EXPECTED_SESSION = format("Optional[%s]", SESSION);
43+
static final String NO_SESSION = "Optional.empty";
4444
static final String URL_ENCODED_SESSION = encode();
4545
private static final String SECRET = "c05ll3lesrinf39t7mc5h6un6r0c69lgfno69dsak3vabeqamouq4328cuaekros401ajdpkh60rrtpd8ro24rbuqmgtnd1ebag6ljnb65i8a55d482ok7o0nch0bfbe";
4646
private static final String MAX_SESSION_AGE = "60 seconds";

0 commit comments

Comments
 (0)