GameResults lack proper information on the game result

[anarchuser]

GameResult (and, in relation, PlayerScore) need a rework. Ideas include:

• Always store both players
  • Store information (enum?) on whether they won, lost or violated
• If rule violation: store MoveMistake in GameResult
  • Display MoveMistake in GUI

Related to software-challenge/gui#7

[xeruf]

@anarchuser is this still relevant?

[anarchuser]

Yes. As listed above, GameResults only store the winner of a game. That means you have to request the opponent of that player through the Game, which is tedious. Storing both players and whether they won, lost, violated or drawed makes this information more accessible.
Also, the GUI currently has no way of knowing MoveMistakes that happened and thus can't display them.

[xeruf]

Fixed in 4cc4190