improve memo, partial, compose, and chain function types (#379)

* improve memo, partial, compose, and chain function types

---------

Co-authored-by: Ray Epps <[email protected]>

Author: sodiray

.github/workflows/test-on-master.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [14.x, 16.x, 18.17.1]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}

.github/workflows/test-on-pr.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [14.x, 16.x, 18.17.1]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
@@ -22,7 +22,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '20.x'
       - run: yarn
       - run: yarn format:check
   verify-cdn-build-matches-src:
@@ -31,7 +31,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '20.x'
       - run: yarn
       - run: npm install -g checksum
       - name: Calc current cdn checksums

cdn/radash.esm.js

@@ -487,15 +487,15 @@ const guard = (func, shouldGuard) => {
 };
 
 function chain(...funcs) {
-  return function forInitialArg(initialArg) {
-    return funcs.reduce((acc, fn) => fn(acc), initialArg);
+  return (...args) => {
+    return funcs.slice(1).reduce((acc, fn) => fn(acc), funcs[0](...args));
   };
 }
-const compose = (...funcs) => {
+function compose(...funcs) {
   return funcs.reverse().reduce((acc, fn) => fn(acc));
-};
+}
 const partial = (fn, ...args) => {
-  return (...rest) => fn(...args, ...rest);
+  return (...rest) => fn(...[...args, ...rest]);
 };
 const partob = (fn, argobj) => {
   return (restobj) => fn({
@@ -711,15 +711,15 @@ const omit = (obj, keys2) => {
 const get = (value, path, defaultValue) => {
   const segments = path.split(/[\.\[\]]/g);
   let current = value;
-  for (let key of segments) {
+  for (const key of segments) {
     if (current === null)
       return defaultValue;
     if (current === void 0)
       return defaultValue;
-    key = key.replace(/['"]/g, "");
-    if (key.trim() === "")
+    const dequoted = key.replace(/['"]/g, "");
+    if (dequoted.trim() === "")
       continue;
-    current = current[key];
+    current = current[dequoted];
   }
   if (current === void 0)
     return defaultValue;

cdn/radash.js

@@ -490,15 +490,15 @@ var radash = (function (exports) {
   };
 
   function chain(...funcs) {
-    return function forInitialArg(initialArg) {
-      return funcs.reduce((acc, fn) => fn(acc), initialArg);
+    return (...args) => {
+      return funcs.slice(1).reduce((acc, fn) => fn(acc), funcs[0](...args));
     };
   }
-  const compose = (...funcs) => {
+  function compose(...funcs) {
     return funcs.reverse().reduce((acc, fn) => fn(acc));
-  };
+  }
   const partial = (fn, ...args) => {
-    return (...rest) => fn(...args, ...rest);
+    return (...rest) => fn(...[...args, ...rest]);
   };
   const partob = (fn, argobj) => {
     return (restobj) => fn({
@@ -714,15 +714,15 @@ var radash = (function (exports) {
   const get = (value, path, defaultValue) => {
     const segments = path.split(/[\.\[\]]/g);
     let current = value;
-    for (let key of segments) {
+    for (const key of segments) {
       if (current === null)
         return defaultValue;
       if (current === void 0)
         return defaultValue;
-      key = key.replace(/['"]/g, "");
-      if (key.trim() === "")
+      const dequoted = key.replace(/['"]/g, "");
+      if (dequoted.trim() === "")
         continue;
-      current = current[key];
+      current = current[dequoted];
     }
     if (current === void 0)
       return defaultValue;

cdn/radash.min.js

@@ -21,28 +21,29 @@ chained(0) // => 10
 chained(7) // => 24
 ```
 
-### More example
+### Example
 ```ts
 import { chain } from 'radash'
 
-type User = { id: number; name: string }
-const users: User[] = [
-  { id: 1, name: 'John Doe' },
-  { id: 2, name: 'John Smith' },
-  { id: 3, name: 'John Wick' }
-]
-function getName<T extends { name: string }>(item: T) {
-  return item.name;
-}
-function upperCase(text: string): Uppercase<string> {
-  return text.toUpperCase() as Uppercase<string>;
+type Deity = { 
+  name: string
+  rank: number 
 }
 
-const getUpperName = chain<User, Uppercase<string>>(getName, upperCase)
-//                     ^ Use chain function here
+const gods: Deity[] = [
+  { rank: 8, name: 'Ra' },
+  { rank: 7, name: 'Zeus' },
+  { rank: 9, name: 'Loki' }
+]
+
+const getName = (god: Deity) => item.name
+const upperCase = (text: string) => text.toUpperCase() as Uppercase<string>
+
+const getUpperName = chain(
+  getName, 
+  upperCase
+)
 
-getUpperName(users[0])                  // => 'JOHN DOE'
-users.map((user) => getUpperName(user)) // => ['JOHN DOE', 'JOHN SMITH', 'JOHN WICK']
-users.map(getUpperName)                 // => ['JOHN DOE', 'JOHN SMITH', 'JOHN WICK']
-//              ^ use chained function as a Point-free
+getUpperName(gods[0])       // => 'RA'
+gods.map(getUpperName)      // => ['RA', 'ZEUS', 'LOKI']
 ```

docs/curry/chain.mdx

@@ -1,6 +1,6 @@
 {
   "name": "radash",
-  "version": "11.0.0",
+  "version": "12.0.0",
   "description": "Functional utility library - modern, simple, typed, powerful",
   "main": "dist/cjs/index.cjs",
   "module": "dist/esm/index.mjs",