-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with node-webkit #216
Comments
More details would be appreciated. I haven't done any testing with node-webkit, but I'm guessing it might set the Origin to something tricky. |
Is there any update on the Issue? |
@bytekoders I'm waiting for more information from @goldfire. If you anyinformation, that would be a lot of help. I need way more detail before I can go about confirming the issue. |
Closing due to insufficient information |
I'm running into this issue and investigating it. The problem arises because of browserify expecting either For example: module.exports = global.WebSocket || global.MozWebSocket; In SockJS' browser build, browserify replaces So this is effectively a problem between browserify and node-webkit. I'm still looking for the right way to fix, in particular if SockJS can do something about it or if the fix should be on the consumer side. Browserify issue: browserify/browserify#1189 Other possibly related issues: browserify/browserify#481, browserify/browserify#1025, browserify/browserify#834. |
Workaround: |
It appears that browserify can fix this without needing SockJS to do anything specific. |
Yes, I agree. |
This is fixed for me with |
Testing on node-webkit 0.10.x and 0.11.x, sock.js 1.0 fails to connect. However, reverting to 0.3.4 works perfectly. I've yet to figure out what might be causing this, but thought someone else might have run into this as well.
The text was updated successfully, but these errors were encountered: