This repository was archived by the owner on Aug 29, 2024. It is now read-only.
PR #72 has introduced a minimum Ruby version requirement of v2.7 #74
Milestone
Comments
|
Ah sorry about that. I’ll bump the minimum supported version in the gemspec. |
dentarg
added a commit
to dentarg/sinatra
that referenced
this issue
Nov 11, 2023
Due to socketry/async-io#72 released in async-io 1.37.0 We will need this fix as long as we want to test Falcon in Ruby 2.6, as the "fix" in async-io will be to raise the min Ruby version: socketry/async-io#74
dentarg
added a commit
to sinatra/sinatra
that referenced
this issue
Nov 11, 2023
Due to socketry/async-io#72 released in async-io 1.37.0 We will need this fix as long as we want to test Falcon in Ruby 2.6, as the "fix" in async-io will be to raise the min Ruby version: socketry/async-io#74 Fail can be seen at https://github.com/sinatra/sinatra/actions/runs/6836408460/job/18591270458#step:5:19
|
Okay, it was an easy fix to restore compatibility, so I've done that. |
|
Sorry, messed up the cross referencing. This was fixed in #75. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#72's use of
array[..n]:won't work with Rubies older than 2.7.
We'll need to either refactor to support Ruby 2.5 and 2.6, or bump the
required_ruby_versionvalue inasycn-io.gemspecaccordingly.The text was updated successfully, but these errors were encountered: