-
-
Notifications
You must be signed in to change notification settings - Fork 46
Strange issues after #198 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks let me take a look today. |
I did a bit more investigating with the latest async gems and I think I got a bit closer to what the actual issue may be. In my case, I have an upstream data source with a "paid" and a "free" option -- I use the "paid" option, but if I have a rate limit error, I fall back to the "free" option, in case my paid subscription fails for some reason. In this case, the "free" option is http, while the "paid" option is https. (http://api.geonames.org vs https://secure.geonames.net) -- I'm still having trouble understanding what might be going wrong in the VCR case. When recording the cassette everything works fine, but on subsequent runs (using the cassette) I get a timeout (no matter how high I set the timeout to be...) I think this weird setup is actually safe for me to remove, but I thought it may be interesting to report, just in case this is helpful for debugging? Let me know if any of this triggers any additional thoughts and I'm happy to help trying to figure out if there's a fixable root issue! Thanks! |
@trevorturk I'm running into another "works on the first run" VCR bug. I'm not using async-http though, so I opened up an issue in the Async repo with a script that reproduces the bug. May or may not be related to this? |
I just saw that come in! Yeah, I'm fairly confident that my issue was to do with multiple hosts, I wonder if you know what HTTP library you're using (under the hood in RubyLLM perhaps? I don't know the gem...) You might also want to check here: https://github.com/search?q=repo%3Avcr%2Fvcr+async&type=issues I had some strange issues with VCR (IIRC something to do with WebMock) that might be worth trying to research... |
RubyLLM uses Faraday under the hood, which I suspect is the problem. I wasn't able to reproduce my bug using async-http + VCR, so our issues might be unrelated. |
I'm not completely sure what's going on yet, but I'm seeing some strange errors (in the test env), perhaps breaking VCR / WebMock compatibility (?) since #198. Reporting before investigating further in case this rings any bells. Thanks!
The text was updated successfully, but these errors were encountered: