Skip to content

Commit 0b97285

Browse files
authored
Migrate to v2 Media for youtube-tracking plugin (#1342)
* Migrate to v2 schemas for youtube-tracking plugin See PE-5753. * Run rush change * Remove unneeded license headers * Add return type for buildYouTubeEntity * Change evaluation of paused state * Add (start/end)YouTubeTracking APIs * Always poll and call updateMediaTracking * Fix seek timestamps * Fix YT e2e tests * rush update * Fix build * Make default ping state explicit
1 parent 65feb91 commit 0b97285

File tree

22 files changed

+1003
-1033
lines changed

22 files changed

+1003
-1033
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@snowplow/browser-plugin-media",
5+
"comment": "Add support for context generator functions",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@snowplow/browser-plugin-media"
10+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@snowplow/browser-plugin-youtube-tracking",
5+
"comment": "Migrate to v2 Media Tracking schemas",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@snowplow/browser-plugin-youtube-tracking"
10+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@snowplow/javascript-tracker",
5+
"comment": "Adjust e2e tests for v2 Media support in YouTube plugin",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@snowplow/javascript-tracker"
10+
}

common/config/rush/pnpm-lock.yaml

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/config/rush/repo-state.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
22
{
3-
"pnpmShrinkwrapHash": "64adeaeaaaae09f264464fa44834bfe036401311",
3+
"pnpmShrinkwrapHash": "ee6607493b34d686c39a612fcb8e407675d4e985",
44
"preferredVersionsHash": "bf21a9e8fbc5a3846fb05b4fa0859e0917b2202f"
55
}

plugins/browser-plugin-youtube-tracking/package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,17 @@
2323
"dependencies": {
2424
"@snowplow/browser-tracker-core": "workspace:*",
2525
"@snowplow/tracker-core": "workspace:*",
26-
"tslib": "^2.3.1"
26+
"@snowplow/browser-plugin-media": "workspace:*",
27+
"tslib": "^2.3.1",
28+
"uuid": "^8.3.2"
2729
},
2830
"devDependencies": {
2931
"@ampproject/rollup-plugin-closure-compiler": "~0.27.0",
3032
"@rollup/plugin-commonjs": "~21.0.2",
3133
"@rollup/plugin-node-resolve": "~13.1.3",
3234
"@types/jest": "~27.4.1",
3335
"@types/jsdom": "~16.2.14",
36+
"@types/uuid": "^8.3.2",
3437
"@types/youtube": "~0.0.46",
3538
"@typescript-eslint/eslint-plugin": "~5.15.0",
3639
"@typescript-eslint/parser": "~5.15.0",

plugins/browser-plugin-youtube-tracking/src/buildYouTubeEvent.ts

Lines changed: 0 additions & 101 deletions
This file was deleted.

plugins/browser-plugin-youtube-tracking/src/constants.ts

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)