Skip to content

Commit f54ab9f

Browse files
sfc-gh-gkannanSnowflake Authors
and
Snowflake Authors
authored
Project import generated by Copybara. (#120)
GitOrigin-RevId: bbba74b134aa6fa9d66cb37f439477b0a94817b0 Co-authored-by: Snowflake Authors <[email protected]>
1 parent 6186ce6 commit f54ab9f

File tree

7 files changed

+18
-31
lines changed

7 files changed

+18
-31
lines changed

.bazelversion

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6.3.0
1+
6.3.2

CHANGELOG.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
# Release History
22

3-
## 1.6.3
3+
## 1.6.4
4+
5+
### Bug Fixes
6+
7+
- Registry: Fix an issue that leads to incident when using `ModelVersion.run` with service.
8+
9+
## 1.6.3 (2024-10-07)
410

511
- Model Registry (PrPr) has been removed.
612

bazel/requirements/templates/meta.tpl.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ build:
1111
requirements:
1212
build:
1313
- python
14-
- bazel==6.3.0
14+
- bazel==6.3.2
1515
run:
1616
- python>=3.8,<3.12
1717

ci/conda_recipe/meta.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ build:
1717
noarch: python
1818
package:
1919
name: snowflake-ml-python
20-
version: 1.6.3
20+
version: 1.6.4
2121
requirements:
2222
build:
2323
- python
24-
- bazel==6.3.0
24+
- bazel==6.3.2
2525
run:
2626
- absl-py>=0.15,<2
2727
- aiohttp!=4.0.0a0, !=4.0.0a1

snowflake/ml/model/_client/sql/service.py

+6-18
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,10 @@
33
import textwrap
44
from typing import Any, Dict, List, Optional, Tuple
55

6-
from packaging import version
7-
86
from snowflake import snowpark
97
from snowflake.ml._internal.utils import (
108
identifier,
119
query_result_checker,
12-
snowflake_env,
1310
sql_identifier,
1411
)
1512
from snowflake.ml.model._client.sql import _base
@@ -120,21 +117,12 @@ def invoke_function_method(
120117
args_sql_list.append(input_arg_value)
121118
args_sql = ", ".join(args_sql_list)
122119

123-
if snowflake_env.get_current_snowflake_version(
124-
self._session, statement_params=statement_params
125-
) >= version.parse("8.39.0"):
126-
fully_qualified_service_name = self.fully_qualified_object_name(
127-
actual_database_name, actual_schema_name, service_name
128-
)
129-
fully_qualified_function_name = f"{fully_qualified_service_name}!{method_name.identifier()}"
130-
131-
else:
132-
function_name = identifier.concat_names([service_name.identifier(), "_", method_name.identifier()])
133-
fully_qualified_function_name = identifier.get_schema_level_object_identifier(
134-
actual_database_name.identifier(),
135-
actual_schema_name.identifier(),
136-
function_name,
137-
)
120+
function_name = identifier.concat_names([service_name.identifier(), "_", method_name.identifier()])
121+
fully_qualified_function_name = identifier.get_schema_level_object_identifier(
122+
actual_database_name.identifier(),
123+
actual_schema_name.identifier(),
124+
function_name,
125+
)
138126

139127
sql = textwrap.dedent(
140128
f"""{with_sql}

snowflake/ml/model/_client/sql/service_test.py

-7
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ def test_deploy_model(self) -> None:
102102
def test_invoke_function_method(self) -> None:
103103
m_statement_params = {"test": "1"}
104104
m_df = mock_data_frame.MockDataFrame()
105-
m_df0 = mock_data_frame.MockDataFrame(collect_result=[Row(CURRENT_VERSION="1")])
106-
self.m_session.add_mock_sql("SELECT CURRENT_VERSION() AS CURRENT_VERSION", m_df0)
107105

108106
self.m_session.add_mock_sql(
109107
"""SELECT *,
@@ -143,9 +141,6 @@ def test_invoke_function_method(self) -> None:
143141

144142
def test_invoke_function_method_1(self) -> None:
145143
m_statement_params = {"test": "1"}
146-
m_df0 = mock_data_frame.MockDataFrame(collect_result=[Row(CURRENT_VERSION="1")])
147-
self.m_session.add_mock_sql("SELECT CURRENT_VERSION() AS CURRENT_VERSION", m_df0)
148-
149144
m_df = mock_data_frame.MockDataFrame()
150145
self.m_session.add_mock_sql(
151146
"""SELECT *,
@@ -188,8 +183,6 @@ def test_invoke_function_method_1(self) -> None:
188183

189184
def test_invoke_function_method_2(self) -> None:
190185
m_statement_params = {"test": "1"}
191-
m_df0 = mock_data_frame.MockDataFrame(collect_result=[Row(CURRENT_VERSION="1")])
192-
self.m_session.add_mock_sql("SELECT CURRENT_VERSION() AS CURRENT_VERSION", m_df0)
193186
m_df = mock_data_frame.MockDataFrame()
194187
self.m_session.add_mock_sql(
195188
"""WITH SNOWPARK_ML_MODEL_INFERENCE_INPUT_ABCDEF0123 AS (query_1)

snowflake/ml/version.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# This is parsed by regex in conda reciper meta file. Make sure not to break it.
2-
VERSION = "1.6.3"
2+
VERSION = "1.6.4"

0 commit comments

Comments
 (0)