Skip to content

Commit 965b9f6

Browse files
smuehlstsmuehlst
committed
fopen() with non-existent file returns non-NULL
Fixes #14.
1 parent 52b0f67 commit 965b9f6

File tree

3 files changed

+141
-126
lines changed

3 files changed

+141
-126
lines changed

‎CHANGELOG.md

+130-125
Original file line numberDiff line numberDiff line change
@@ -1,125 +1,130 @@
1-
# Release History
2-
3-
## [v15.3](https://github.com/smuehlst/circle-stdlib/releases/tag/v15.3)
4-
5-
* Synced with [Circle Step 43.1](https://github.com/rsta2/circle/releases/tag/Step43.1).
6-
* Updated mbedtls to [release 2.16.8](https://github.com/ARMmbed/mbedtls/releases/tag/mbedtls-2.16.8).
7-
8-
## [v15.2](https://github.com/smuehlst/circle-stdlib/releases/tag/v15.2)
9-
10-
* Synced with [Circle Step 43](https://github.com/rsta2/circle/releases/tag/Step43).
11-
12-
## [v15.1](https://github.com/smuehlst/circle-stdlib/releases/tag/v15.1)
13-
14-
* Synced with [Circle Step 42.1](https://github.com/rsta2/circle/releases/tag/Step42.1).
15-
* Support for new WLAN features of Circle.
16-
17-
## [v15](https://github.com/smuehlst/circle-stdlib/releases/tag/v15)
18-
19-
* Additional file-related capabilities of [FatFs](http://elm-chan.org/fsw/ff/00index_e.html) available now:
20-
* File seeking in stdio and in the C++ standard library.
21-
* Directory operations rename(), mkdir() and unlink().
22-
* Extended the smoke test run by the [GitHub action](https://github.com/smuehlst/circle-stdlib/actions) with basic tests for file operations.
23-
24-
## [v14](https://github.com/smuehlst/circle-stdlib/releases/tag/v14)
25-
26-
* Synced with [Circle Step 42](https://github.com/rsta2/circle/releases/tag/Step42).
27-
* Switched the FAT filesystem implementation to [FatFs](http://elm-chan.org/fsw/ff/00index_e.html).
28-
While FatFs offers more features than Circle's FAT filesystem implementation that was used previously,
29-
this release of circle-stdlib only aims to be compatible with previous releases regarding
30-
filesystem-related functionality.
31-
32-
## [v13.2](https://github.com/smuehlst/circle-stdlib/releases/tag/v13.2)
33-
34-
* Synced with [Circle Step 41.2](https://github.com/rsta2/circle/releases/tag/Step41.2).
35-
36-
## [v13.1](https://github.com/smuehlst/circle-stdlib/releases/tag/v13.1)
37-
38-
* Synced with [Circle Step 41.1](https://github.com/rsta2/circle/releases/tag/Step41.1).
39-
* Minor fix in the README.md file.
40-
41-
## [v13.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v13.0)
42-
43-
* Synced with [Circle Step 41](https://github.com/rsta2/circle/releases/tag/Step41).
44-
* Updated mbedtls to [release 2.16.4](https://github.com/ARMmbed/mbedtls/releases/tag/mbedtls-2.16.4).
45-
* New [configure](configure) option `--qemu` to build with support for QEMU semihosting mode.
46-
* Added [GitHub action](https://github.com/smuehlst/circle-stdlib/actions) that builds
47-
with the supported compilers in 32-bit and 64-bit mode and runs a smoke test under QEMU.
48-
* Minor changes to circle-stdlib and mbedtls samples so they terminate under QEMU.
49-
50-
Thanks to Rene Stange for making it possible to run Circle programs under QEMU in
51-
a fully automated manner.
52-
53-
## [v12.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v12.0)
54-
55-
* Updated circle-newlib from upstream to fix a compilation error in the C++ sample when using gcc 8.3-2019.03.
56-
57-
## [v11.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v11.0)
58-
59-
* Synced with [Circle Step 40](https://github.com/rsta2/circle/releases/tag/Step40).
60-
* Raspberry Pi 4 support.
61-
62-
## [v10.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v10.0)
63-
64-
* Synced with [Circle Step 39.2](https://github.com/rsta2/circle/releases/tag/Step39.2).
65-
66-
## [v9.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v9.0)
67-
68-
* Synced with [Circle Step 39.1](https://github.com/rsta2/circle/releases/tag/Step39.1).
69-
* AArch64 support.
70-
* Removed deprecated build script `build.bash` (use `configure` and `make` instead).
71-
72-
## [v8.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v8.0)
73-
74-
* Synced with [Circle Step 39](https://github.com/rsta2/circle/releases/tag/Step39).
75-
* [mbed TLS](libs/mbedtls) support updated to release 2.16.0.
76-
77-
## [v7.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v7.0)
78-
79-
* Synced with [Circle Step 37](https://github.com/rsta2/circle/releases/tag/Step37).
80-
* [mbed TLS](libs/mbedtls) support updated to release 2.14.1.
81-
* Circle is now included from its default repository. To sync an existing clone of the circle-stdlib repository, enter the following commands:
82-
83-
```bash
84-
git submodule sync libs/circle
85-
git submodule update --init --remote libs/circle
86-
```
87-
88-
## [v6.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v6.0)
89-
90-
* Synced with [Circle Step 36](https://github.com/rsta2/circle/releases/tag/Step36).
91-
92-
## [v5.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v5.0)
93-
94-
* Synced with [Circle Step 35.1](https://github.com/rsta2/circle/releases/tag/Step35.1).
95-
* Added support for <dirent.h> functions.
96-
* Added support for time()-related functions.
97-
* [mbed TLS](libs/mbedtls) support implemented by Rene Stange.
98-
* Added `configure` script and `Makefile` to replace `build.bash`. build.bash is
99-
deprecated and will be removed in a future release.
100-
101-
## [v4.0](https://github.com/smuehlst/circle-stdlib/tree/v4.0)
102-
103-
* Synced with [Circle Step 34](https://github.com/rsta2/circle/releases/tag/Step34).
104-
* Added CStdlibApp, CStdlibAppScreen, CStdlibAppStdio and CStdlibAppNetwork for
105-
easier application creation (thanks to Rene Stange).
106-
107-
## [v3.0](https://github.com/smuehlst/circle-stdlib/tree/V3.0)
108-
109-
* Synced with [Circle Step 33](https://github.com/rsta2/circle/releases/tag/Step33).
110-
* Implemented stdin/stdout/stderr based on Circle's CConsole class.
111-
* A build of circle-stdlib with ARM gcc toolchains that include Newlib out-of-the-box now provides
112-
support for C and C++ standard libraries. This is due to the fact that the Newlib provided by the toolchain
113-
is replaced by circle-stdlib's Newlib build, and the toolchain's standard C++ library works with the
114-
replaced Newlib.
115-
116-
## [v2.0](https://github.com/smuehlst/circle-stdlib/tree/v2.0)
117-
118-
This release implements Newlib's open(), close(), read() and write()
119-
system calls bases on Circle's I/O functions. This enables stdio functionality.
120-
A small [test program](samples/03-stdio-fatfs) demonstrates the use of
121-
stdio file system functions with Circle.
122-
123-
## [v1.0](https://github.com/smuehlst/circle-stdlib/tree/v1.0)
124-
125-
Initial build of Newlib with Circle, without any systems calls being implemented.
1+
# Release History
2+
3+
## [v15.4](https://github.com/smuehlst/circle-stdlib/releases/tag/v15.4)
4+
5+
* Fixed issue #14: fopen() returned non-NULL value when opening non-existent
6+
file for reading.
7+
8+
## [v15.3](https://github.com/smuehlst/circle-stdlib/releases/tag/v15.3)
9+
10+
* Synced with [Circle Step 43.1](https://github.com/rsta2/circle/releases/tag/Step43.1).
11+
* Updated mbedtls to [release 2.16.8](https://github.com/ARMmbed/mbedtls/releases/tag/mbedtls-2.16.8).
12+
13+
## [v15.2](https://github.com/smuehlst/circle-stdlib/releases/tag/v15.2)
14+
15+
* Synced with [Circle Step 43](https://github.com/rsta2/circle/releases/tag/Step43).
16+
17+
## [v15.1](https://github.com/smuehlst/circle-stdlib/releases/tag/v15.1)
18+
19+
* Synced with [Circle Step 42.1](https://github.com/rsta2/circle/releases/tag/Step42.1).
20+
* Support for new WLAN features of Circle.
21+
22+
## [v15](https://github.com/smuehlst/circle-stdlib/releases/tag/v15)
23+
24+
* Additional file-related capabilities of [FatFs](http://elm-chan.org/fsw/ff/00index_e.html) available now:
25+
* File seeking in stdio and in the C++ standard library.
26+
* Directory operations rename(), mkdir() and unlink().
27+
* Extended the smoke test run by the [GitHub action](https://github.com/smuehlst/circle-stdlib/actions) with basic tests for file operations.
28+
29+
## [v14](https://github.com/smuehlst/circle-stdlib/releases/tag/v14)
30+
31+
* Synced with [Circle Step 42](https://github.com/rsta2/circle/releases/tag/Step42).
32+
* Switched the FAT filesystem implementation to [FatFs](http://elm-chan.org/fsw/ff/00index_e.html).
33+
While FatFs offers more features than Circle's FAT filesystem implementation that was used previously,
34+
this release of circle-stdlib only aims to be compatible with previous releases regarding
35+
filesystem-related functionality.
36+
37+
## [v13.2](https://github.com/smuehlst/circle-stdlib/releases/tag/v13.2)
38+
39+
* Synced with [Circle Step 41.2](https://github.com/rsta2/circle/releases/tag/Step41.2).
40+
41+
## [v13.1](https://github.com/smuehlst/circle-stdlib/releases/tag/v13.1)
42+
43+
* Synced with [Circle Step 41.1](https://github.com/rsta2/circle/releases/tag/Step41.1).
44+
* Minor fix in the README.md file.
45+
46+
## [v13.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v13.0)
47+
48+
* Synced with [Circle Step 41](https://github.com/rsta2/circle/releases/tag/Step41).
49+
* Updated mbedtls to [release 2.16.4](https://github.com/ARMmbed/mbedtls/releases/tag/mbedtls-2.16.4).
50+
* New [configure](configure) option `--qemu` to build with support for QEMU semihosting mode.
51+
* Added [GitHub action](https://github.com/smuehlst/circle-stdlib/actions) that builds
52+
with the supported compilers in 32-bit and 64-bit mode and runs a smoke test under QEMU.
53+
* Minor changes to circle-stdlib and mbedtls samples so they terminate under QEMU.
54+
55+
Thanks to Rene Stange for making it possible to run Circle programs under QEMU in
56+
a fully automated manner.
57+
58+
## [v12.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v12.0)
59+
60+
* Updated circle-newlib from upstream to fix a compilation error in the C++ sample when using gcc 8.3-2019.03.
61+
62+
## [v11.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v11.0)
63+
64+
* Synced with [Circle Step 40](https://github.com/rsta2/circle/releases/tag/Step40).
65+
* Raspberry Pi 4 support.
66+
67+
## [v10.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v10.0)
68+
69+
* Synced with [Circle Step 39.2](https://github.com/rsta2/circle/releases/tag/Step39.2).
70+
71+
## [v9.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v9.0)
72+
73+
* Synced with [Circle Step 39.1](https://github.com/rsta2/circle/releases/tag/Step39.1).
74+
* AArch64 support.
75+
* Removed deprecated build script `build.bash` (use `configure` and `make` instead).
76+
77+
## [v8.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v8.0)
78+
79+
* Synced with [Circle Step 39](https://github.com/rsta2/circle/releases/tag/Step39).
80+
* [mbed TLS](libs/mbedtls) support updated to release 2.16.0.
81+
82+
## [v7.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v7.0)
83+
84+
* Synced with [Circle Step 37](https://github.com/rsta2/circle/releases/tag/Step37).
85+
* [mbed TLS](libs/mbedtls) support updated to release 2.14.1.
86+
* Circle is now included from its default repository. To sync an existing clone of the circle-stdlib repository, enter the following commands:
87+
88+
```bash
89+
git submodule sync libs/circle
90+
git submodule update --init --remote libs/circle
91+
```
92+
93+
## [v6.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v6.0)
94+
95+
* Synced with [Circle Step 36](https://github.com/rsta2/circle/releases/tag/Step36).
96+
97+
## [v5.0](https://github.com/smuehlst/circle-stdlib/releases/tag/v5.0)
98+
99+
* Synced with [Circle Step 35.1](https://github.com/rsta2/circle/releases/tag/Step35.1).
100+
* Added support for <dirent.h> functions.
101+
* Added support for time()-related functions.
102+
* [mbed TLS](libs/mbedtls) support implemented by Rene Stange.
103+
* Added `configure` script and `Makefile` to replace `build.bash`. build.bash is
104+
deprecated and will be removed in a future release.
105+
106+
## [v4.0](https://github.com/smuehlst/circle-stdlib/tree/v4.0)
107+
108+
* Synced with [Circle Step 34](https://github.com/rsta2/circle/releases/tag/Step34).
109+
* Added CStdlibApp, CStdlibAppScreen, CStdlibAppStdio and CStdlibAppNetwork for
110+
easier application creation (thanks to Rene Stange).
111+
112+
## [v3.0](https://github.com/smuehlst/circle-stdlib/tree/V3.0)
113+
114+
* Synced with [Circle Step 33](https://github.com/rsta2/circle/releases/tag/Step33).
115+
* Implemented stdin/stdout/stderr based on Circle's CConsole class.
116+
* A build of circle-stdlib with ARM gcc toolchains that include Newlib out-of-the-box now provides
117+
support for C and C++ standard libraries. This is due to the fact that the Newlib provided by the toolchain
118+
is replaced by circle-stdlib's Newlib build, and the toolchain's standard C++ library works with the
119+
replaced Newlib.
120+
121+
## [v2.0](https://github.com/smuehlst/circle-stdlib/tree/v2.0)
122+
123+
This release implements Newlib's open(), close(), read() and write()
124+
system calls bases on Circle's I/O functions. This enables stdio functionality.
125+
A small [test program](samples/03-stdio-fatfs) demonstrates the use of
126+
stdio file system functions with Circle.
127+
128+
## [v1.0](https://github.com/smuehlst/circle-stdlib/tree/v1.0)
129+
130+
Initial build of Newlib with Circle, without any systems calls being implemented.

‎libs/circle-newlib

‎samples/05-smoketest/kernel.cpp

+10
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,16 @@ CKernel::IoTest (void)
161161

162162
Report ("fclose () test succeeded");
163163

164+
// Test for issue #14
165+
fp = fopen ("this file does not exist", "r");
166+
if (fp != nullptr)
167+
{
168+
Report ("fopen () for non-existent file unexpectedly succeeded");
169+
exit (1);
170+
}
171+
mLogger.Write (GetKernelName (), LogNotice,
172+
"fopen () for non-existent file failed as expected with errno %d", errno);
173+
164174
Report ("Test directory operations...");
165175

166176
string const dirname = "subdir";

0 commit comments

Comments
 (0)