Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor character not looking ok #42

Closed
romgrk opened this issue Nov 1, 2020 · 2 comments · Fixed by #44
Closed

Cursor character not looking ok #42

romgrk opened this issue Nov 1, 2020 · 2 comments · Fixed by #44
Labels
bug Something isn't working gui Bugs or enhancement related to GUI elements

Comments

@romgrk
Copy link

romgrk commented Nov 1, 2020

The cursor character doesn't use the same font as the editor therefore it doesn't display characters the same way. Also it's not positioned correctly.

Screenshot from 2020-10-31 23-29-04

@smolck
Copy link
Owner

smolck commented Nov 1, 2020

From #40 (comment):

The cursor char is rendered as a HTML/DOM node. It's a z-index thing because I was too lazy to implement the cursor in WebGL.

I guess the proper solution is to implement this in WebGL then, but that might take a good bit of work; a faster fix is probably to just change a few CSS props on the cursor div/span.

@smolck
Copy link
Owner

smolck commented Nov 2, 2020

So, bit of a status report; drawing just the cursor block with webgl is fairly trivial (which I've done in #44), you just change the background color of the current cell (doesn't quite work with multiple windows though, but hopefully soon). However, I don't really know how to go about drawing the other cursor cursor shapes, specifically the line shape.

@smolck smolck added bug Something isn't working gui Bugs or enhancement related to GUI elements labels Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui Bugs or enhancement related to GUI elements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants