You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recently after adding the crc64fast-nvme crate we have encountered numerous build issues both externally and internally. This was due to an issue in how cbindgen uses cargo metadata and it being an unflagged build-time dependency of crc64fast-nvme (see this issue for details). We missed this in our testing because all of our tests are performed in network-available environments (GH Actions, Codebuild) and so the odd dependencies could still be downloaded even though not initially picked up by Cargo.
To avoid this issue recurring in the future we should add some sort of sandboxed build to our CI to ensure that none of our dependencies will fail in those environments.
@landonxjames LMK if you'd like help or feedback regarding e.g. a Bazel or Nix build. We run many such sandboxed builds for Rust, both via coarse-grained sandboxes (Cargo in Nix) and Bazel (per-action sandboxing).
Recently after adding the crc64fast-nvme crate we have encountered numerous build issues both externally and internally. This was due to an issue in how
cbindgen
usescargo metadata
and it being an unflagged build-time dependency ofcrc64fast-nvme
(see this issue for details). We missed this in our testing because all of our tests are performed in network-available environments (GH Actions, Codebuild) and so the odd dependencies could still be downloaded even though not initially picked up by Cargo.To avoid this issue recurring in the future we should add some sort of sandboxed build to our CI to ensure that none of our dependencies will fail in those environments.
Links:
c-bindings
feature flag awesomized/crc64fast-nvme#6cbindgen
issue: Ignore dev-dependencies mozilla/cbindgen#666The text was updated successfully, but these errors were encountered: