Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sandboxed build testing to our CI #3981

Open
landonxjames opened this issue Jan 22, 2025 · 1 comment
Open

Add sandboxed build testing to our CI #3981

landonxjames opened this issue Jan 22, 2025 · 1 comment

Comments

@landonxjames
Copy link
Contributor

landonxjames commented Jan 22, 2025

Recently after adding the crc64fast-nvme crate we have encountered numerous build issues both externally and internally. This was due to an issue in how cbindgen uses cargo metadata and it being an unflagged build-time dependency of crc64fast-nvme (see this issue for details). We missed this in our testing because all of our tests are performed in network-available environments (GH Actions, Codebuild) and so the odd dependencies could still be downloaded even though not initially picked up by Cargo.

To avoid this issue recurring in the future we should add some sort of sandboxed build to our CI to ensure that none of our dependencies will fail in those environments.

Links:

@aaronmondal
Copy link

@landonxjames LMK if you'd like help or feedback regarding e.g. a Bazel or Nix build. We run many such sandboxed builds for Rust, both via coarse-grained sandboxes (Cargo in Nix) and Bazel (per-action sandboxing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants