feat: add EnableAwsChunked signing attribute (#1039)

Author: lauzadis

.changes/fb91506d-98b4-4344-bf8b-c1527afe002c.json

@@ -0,0 +1,5 @@
+{
+    "id": "fb91506d-98b4-4344-bf8b-c1527afe002c",
+    "type": "feature",
+    "description": "Add `EnableAwsChunked` signing attribute"
+}

runtime/auth/aws-signing-common/api/aws-signing-common.api

@@ -52,6 +52,7 @@ public final class aws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAlgorithm
 public final class aws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAttributes {
 	public static final field INSTANCE Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAttributes;
 	public final fun getCredentialsProvider ()Laws/smithy/kotlin/runtime/collections/AttributeKey;
+	public final fun getEnableAwsChunked ()Laws/smithy/kotlin/runtime/collections/AttributeKey;
 	public final fun getHashSpecification ()Laws/smithy/kotlin/runtime/collections/AttributeKey;
 	public final fun getNormalizeUriPath ()Laws/smithy/kotlin/runtime/collections/AttributeKey;
 	public final fun getRequestSignature ()Laws/smithy/kotlin/runtime/collections/AttributeKey;

runtime/auth/aws-signing-common/common/src/aws/smithy/kotlin/runtime/auth/awssigning/AwsSigningAttributes.kt

@@ -78,4 +78,12 @@ public object AwsSigningAttributes {
      * Flag indicating whether to normalize the URI path. See [AwsSigningConfig.normalizeUriPath] for more details.
      */
     public val NormalizeUriPath: AttributeKey<Boolean> = AttributeKey("aws.smithy.kotlin.signing#NormalizeUriPath")
+
+    /**
+     * Flag indicating whether to enable sending requests with `aws-chunked` content encoding. Defaults to `false`.
+     * Note: This flag does not solely control aws-chunked behavior. The size of the request body must also be above a
+     * defined threshold in order to be chunked.
+     * @see <a href="https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html">SigV4 Streaming</a>
+     */
+    public val EnableAwsChunked: AttributeKey<Boolean> = AttributeKey("aws.smithy.kotlin.signing#EnableAwsChunked")
 }

runtime/auth/http-auth-aws/common/src/aws/smithy/kotlin/runtime/http/auth/AwsHttpSigner.kt

@@ -125,6 +125,8 @@ public class AwsHttpSigner(private val config: Config) : HttpSigner {
         val contextNormalizeUriPath = attributes.getOrNull(AwsSigningAttributes.NormalizeUriPath)
         val contextSigningServiceName = attributes.getOrNull(AwsSigningAttributes.SigningService)
 
+        val enableAwsChunked = attributes.getOrNull(AwsSigningAttributes.EnableAwsChunked) ?: false
+
         // operation signing config is baseConfig + operation specific config/overrides
         val signingConfig = AwsSigningConfig {
             service = contextSigningServiceName ?: checkNotNull(config.service)
@@ -156,7 +158,7 @@ public class AwsHttpSigner(private val config: Config) : HttpSigner {
             hashSpecification = when {
                 contextHashSpecification != null -> contextHashSpecification
                 body is HttpBody.Empty -> HashSpecification.EmptyBody
-                body.isEligibleForAwsChunkedStreaming -> {
+                body.isEligibleForAwsChunkedStreaming && enableAwsChunked -> {
                     if (request.headers.contains("x-amz-trailer")) {
                         if (config.isUnsignedPayload) HashSpecification.StreamingUnsignedPayloadWithTrailers else HashSpecification.StreamingAws4HmacSha256PayloadWithTrailers
                     } else {

runtime/auth/http-auth-aws/common/test/aws/smithy/kotlin/runtime/http/auth/AwsHttpSignerTestBase.kt

@@ -77,6 +77,7 @@ public abstract class AwsHttpSignerTestBase(
                 set(AwsSigningAttributes.SigningRegion, "us-east-1")
                 set(AwsSigningAttributes.SigningDate, Instant.fromIso8601("2020-10-16T19:56:00Z"))
                 set(AwsSigningAttributes.SigningService, "demo")
+                set(AwsSigningAttributes.EnableAwsChunked, true)
             }
         }